New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714615 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----

Blocking:
issue 715077



Sign in to add a comment

Drop SiteBoundCredential concept in favor of a CredentialUserData mixin in CM API

Project Member Reported by jdoerrie@chromium.org, Apr 24 2017

Issue description

IMPORTANT:
- This launch issue is used for standards and implementation tracking only.
It is NOT for Chrome approval regarding privacy, security, legal, UI,
testing,
accessibility etc.
- An overview of the different launch issues can be found here:
http://bit.ly/2ncKZfp
- If your feature requires security / privacy / etc approval then seek a PM
to guide you through the go/newchromefeature process

See http://www.chromium.org/blink#launch-process for an overview of the
Blink launch process, but note this doesn't cover security / privacy / etc
reviews as discussed above.

----------

Change description:
This change drops the SiteBoundCredential interface in
favor of a CredentialUserData mixin. This change was introduced in the
Credential Manager API specification with commit
a43865bd8aa9842dbc8d8e688d5668c087677eac
(https://github.com/w3c/webappsec-credential-management/commit/a43865bd8aa9842dbc8d8e688d5668c087677eac). 

Changes to API surface:
- Deprecation and deletion of |SiteBoundCredential|
- Introduction of |CredentialUserData| mixin
- |PasswordCredential| and |FederatedCredential| inherit directly from |Credential| and implement |CredentialUserData|

Links:
Public standards discussion: https://github.com/w3c/webappsec-credential-management/issues

Support in other browsers:
Internet Explorer: NA
Firefox:           NA
Safari:            NA
 
Blocking: 715077
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850

commit c95e21cadda8ce43f68dc87d1c65d3ae39ab7850
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Apr 26 12:34:59 2017

Drop SiteBoundCredential in favor of CredentialUserData

This change implements dropping the SiteBoundCredential interface in
favor of the CredentialUserData mixin. This change was introduced in the
Credential Manager API specification with commit
a43865bd8aa9842dbc8d8e688d5668c087677eac
(https://github.com/w3c/webappsec-credential-management/commit/a43865bd8aa9842dbc8d8e688d5668c087677eac).

Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

R=vasilii@chromium.org,mkwst@chromium.org,jochen@chromium.org
BUG= 714615 

Review-Url: https://codereview.chromium.org/2832813002
Cr-Commit-Position: refs/heads/master@{#467305}

[rename] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https-expected.txt
[rename] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/BUILD.gn
[rename] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.cpp
[rename] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.h
[rename] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/CredentialUserData.idl
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl
[modify] https://crrev.com/c95e21cadda8ce43f68dc87d1c65d3ae39ab7850/third_party/WebKit/Source/modules/modules_idl_files.gni

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3965ba442d09131dd9e2e4fd576cddab672c4f29

commit 3965ba442d09131dd9e2e4fd576cddab672c4f29
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue May 09 18:29:44 2017

Remove {LocallyStored,SiteBound}CredentialData

This change removes |LocallyStoredCredentialData| and
|SiteBoundCredentialData| in favor of adding the corresponding
attributes to PasswordCredentialData and FederatedCredentialData
directly.

This is a follow up to dropping SiteBoundCredential in r467305.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X-5zjSOzLC4

BUG= 714615 

Review-Url: https://codereview.chromium.org/2867643004
Cr-Commit-Position: refs/heads/master@{#470389}

[modify] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html
[modify] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp
[modify] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h
[modify] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.idl
[delete] https://crrev.com/d063660bf41b8868f1fa6323f0dc59e45ba8b189/third_party/WebKit/Source/modules/credentialmanager/FederatedCredentialData.idl
[add] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/third_party/WebKit/Source/modules/credentialmanager/FederatedCredentialInit.idl
[delete] https://crrev.com/d063660bf41b8868f1fa6323f0dc59e45ba8b189/third_party/WebKit/Source/modules/credentialmanager/LocallyStoredCredentialData.idl
[modify] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialData.idl
[modify] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/3965ba442d09131dd9e2e4fd576cddab672c4f29/tools/blink_rename_merge_helper/data/idl_blocklist.txt

Sign in to add a comment