New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714614 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 14
Cc:
EstimatedDays: ----
NextAction: 2018-07-11
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue crashpad:180
issue 714581



Sign in to add a comment

File descriptor exhaustion on macOS

Project Member Reported by mark@chromium.org, Apr 24 2017

Issue description

I’ve seen a few crash reports that can be attributed to file descriptor exhaustion. This could be per-process file descriptor exhaustion (EMFILE) but is more likely to be systemwide file descriptor exhaustion (ENFILE). The default value of kern.maxfiles on macOS is 12,288. The default per-process RLIMIT_NOFILE is 256, but Chrome bumps this up to 8,192.

Bug 714581 and bug crashpad:180 are suspected to be caused by file descriptor exhaustion.
 

Comment 1 by shrike@chromium.org, Apr 24 2017

Cc: shrike@chromium.org
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 25 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by lgrey@chromium.org, Apr 26 2018

Labels: -Hotlist-Recharge-Cold
NextAction: 2018-07-11
Status: Available (was: Untriaged)
I think this is still an issue but mark@ has the best context, so setting NextAction for a date I think he might be back from leave.
The NextAction date has arrived: 2018-07-11
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.
Owner: mark@chromium.org
Status: Assigned (was: Untriaged)
Mark is there something constructive we can do here, or should we just close it out?
Status: WontFix (was: Assigned)
I think this is OK to close now.

Robert’s working separately on some things that should cut down on Chrome’s file descriptor use. Otherwise, where we’re just hitting the system limit, there’s not much more to do than cry.

But I haven’t seen an unusually high number of these lately.
Project Member

Comment 8 by bugdroid1@chromium.org, Yesterday (28 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a72c20e443285e06e064e67ec754d4f60d4e6d22

commit a72c20e443285e06e064e67ec754d4f60d4e6d22
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Jan 22 19:58:54 2019

Mac: Record via metrics the number of open FDs and the soft FD limit.

The histograms already exist on Linux, CrOS, and Android, so this simply
wires up the values for macOS.

In addition, this enables the FD count column in the Task Manager, since
the data are now readily available.

Bug:  714614 
Change-Id: I05f8063e8d89d3c6cdc68062bf4e591d3af9559c
Reviewed-on: https://chromium-review.googlesource.com/c/1423339
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624881}
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/base/process/process_metrics.h
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/base/process/process_metrics_mac.cc
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/base/process/process_metrics_unittest.cc
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/memory_details_mac.cc
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/task_manager/sampling/task_group_sampler.cc
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/task_manager/sampling/task_group_sampler.h
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/a72c20e443285e06e064e67ec754d4f60d4e6d22/chrome/browser/ui/task_manager/task_manager_table_model.cc

Project Member

Comment 9 by bugdroid, Today (2 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e9d4c23c1287daed49121f1e5488b60450ea16f

commit 6e9d4c23c1287daed49121f1e5488b60450ea16f
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Wed Jan 23 04:27:48 2019

Revert "Mac: Record via metrics the number of open FDs and the soft FD limit."

This reverts commit a72c20e443285e06e064e67ec754d4f60d4e6d22.

Reason for revert: broke ProcessMetricsTest.GetChildOpenFdCount on Mac 10

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38668
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38669

Original change's description:
> Mac: Record via metrics the number of open FDs and the soft FD limit.
> 
> The histograms already exist on Linux, CrOS, and Android, so this simply
> wires up the values for macOS.
> 
> In addition, this enables the FD count column in the Task Manager, since
> the data are now readily available.
> 
> Bug:  714614 
> Change-Id: I05f8063e8d89d3c6cdc68062bf4e591d3af9559c
> Reviewed-on: https://chromium-review.googlesource.com/c/1423339
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624881}

TBR=thakis@chromium.org,afakhry@chromium.org,rsesek@chromium.org,mark@chromium.org

Change-Id: Ic5076dc83b850c28059265de99609e55d86a53d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  714614 
Reviewed-on: https://chromium-review.googlesource.com/c/1429303
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625088}

Project Member

Comment 10 by bugdroid, Today (2 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3aff3364f597ac6b4b32aae9b140b09153da649b

commit 3aff3364f597ac6b4b32aae9b140b09153da649b
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Jan 23 20:16:16 2019

Reland "Mac: Record via metrics the number of open FDs and the soft FD limit."

This is a reland of a72c20e443285e06e064e67ec754d4f60d4e6d22

Fixes ProcessMetricsTest.GetChildOpenFdCount to not close guarded
FDs on macOS 10.10 and 10.11.

Original change's description:
> Mac: Record via metrics the number of open FDs and the soft FD limit.
>
> The histograms already exist on Linux, CrOS, and Android, so this simply
> wires up the values for macOS.
>
> In addition, this enables the FD count column in the Task Manager, since
> the data are now readily available.
>
> Bug:  714614 
> Change-Id: I05f8063e8d89d3c6cdc68062bf4e591d3af9559c
> Reviewed-on: https://chromium-review.googlesource.com/c/1423339
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624881}

Tbr: thakis@chromium.org
Bug:  714614 
Change-Id: Icc79aa88826e9079845f06ed6c3f52139713b404
Reviewed-on: https://chromium-review.googlesource.com/c/1430719
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625329}

Sign in to add a comment