Issue metadata
Sign in to add a comment
|
Regression: Images on the amazon.in does not block after blocking from chrome://settings/content/images
Reported by
svich...@etouch.net,
Apr 24 2017
|
||||||||||||||||||||||||
Issue descriptionChrome Version:59.0.3071.21 Revision f7ed5b73ba2bc808b7a6b056f48e62205274e0ee-refs/branch-heads/3071@{#145} Os: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS) Pre-condition: Add http://www.amazon.in site into block exception of chrome://settings/content/images What steps will reproduce the problem? (1) Launch Chrome, Navigate to http://www.amazon.in (2) Observe images on the page Actual- Images on the page does not block. Expected- Images should be blocked on the page. This is Regression issue, broken in M54 and below is bisect info: Good Build - 54.0.2824.0 Bad Build - 54.0.2825.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/f6c9b6f8d1880e0746a1e7cd1712d8c541264cdd..5bc62a8764ac6b005c185526f58ed82b39413268?pretty=fuller&n=100 Suspect: r410632
,
Apr 25 2017
With respect to comment 1: Rechecked on latest build i.e. 60.0.3080.0 issue is reproducible even if revisited or reloaded the http://www.amazon.in site after blocking images. Kindly refer the attached video for the same Thank you.
,
Apr 28 2017
,
Apr 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8638bd4941bbccbfa49ece2ca400807b067cd6ae commit 8638bd4941bbccbfa49ece2ca400807b067cd6ae Author: dschuyler <dschuyler@chromium.org> Date: Sat Apr 29 00:59:22 2017 [MD settings] omit embeddingOrigin for site exceptions This CL changes how the embeddingOrigin is set on content exceptions. This is now more like it was done in the old options, where the embedding origin was not sent from JavaScript. BUG= 714584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2848933003 Cr-Commit-Position: refs/heads/master@{#468199} [modify] https://crrev.com/8638bd4941bbccbfa49ece2ca400807b067cd6ae/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
,
Apr 29 2017
,
May 2 2017
Verified fix on canary.
,
May 2 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af11c8deb15330c1ad081e414de37cd740b3918b commit af11c8deb15330c1ad081e414de37cd740b3918b Author: Dave Schuyler <dschuyler@chromium.org> Date: Tue May 02 22:56:39 2017 [MD settings] omit embeddingOrigin for site exceptions This CL changes how the embeddingOrigin is set on content exceptions. This is now more like it was done in the old options, where the embedding origin was not sent from JavaScript. BUG= 714584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2848933003 Cr-Commit-Position: refs/heads/master@{#468199} (cherry picked from commit 8638bd4941bbccbfa49ece2ca400807b067cd6ae) Review-Url: https://codereview.chromium.org/2861543002 . Cr-Commit-Position: refs/branch-heads/3071@{#364} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/af11c8deb15330c1ad081e414de37cd740b3918b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
,
May 3 2017
Rechecked the issue on chrome version 59.0.3071.36 on Windows 10, MAC 10.12.4, Ubuntu 14.04. Fix is working as intended. Images are blocked once the site (www.amazon.in) is added into exception list of chrome://settings/content/images. Adding TE-verified labels. Thanks.! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by finnur@chromium.org
, Apr 24 2017