Do not upload in-progress zipping file on Drive |
||||||||||||
Issue descriptionChrome Version: ToT OS: Chrome OS What steps will reproduce the problem? (1) Enable --enable-zip-archiver-on-file-manager flag. (2) Right click any folder on Drive and compress it to a file on Drive. (3) Chrome OS keeps uploading in-progress zipping file on Drive. What is the expected result? Chrome OS should not upload in-progress zipping file again and again. What happens instead? Chrome OS keep uploading in-progress zipping file.
,
Dec 27 2017
,
Dec 28 2017
,
Jan 9 2018
Removing 690217 from blocking, because this will not affect the unpacking function.
,
Jan 15 2018
,
Jan 16 2018
,
Feb 5 2018
Issue 785096 has been merged into this issue.
,
Feb 16 2018
<files-triage>
,
Feb 22 2018
,
Feb 28 2018
,
Mar 15 2018
,
Mar 15 2018
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c5d3313ebb5a367620458189b41c9663cb730c4 commit 6c5d3313ebb5a367620458189b41c9663cb730c4 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Mon Apr 02 12:06:28 2018 Create zip file in temporary storage. This will avoid exposing in-progress zip file to the destination folder. It will resolve the issues like: - the zip file is synced to Drive with incomplete state, having multiple revisions - when cancelling zip packing, the file appears in the trash of Drive Bug: 714579 ,785096,785093,785086, 797873 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0b32515d5e896d87e1dee499f1eea40dd7a481f0 Reviewed-on: https://chromium-review.googlesource.com/844442 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547428} [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/js/background.js [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/js/compressor.js [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/manifest.json
,
Apr 3 2018
,
Apr 3 2018
Issue 785093 has been merged into this issue.
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/798c3cbb70fe157c1780ac3b613f8960647389a1 commit 798c3cbb70fe157c1780ac3b613f8960647389a1 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Thu Apr 05 07:30:22 2018 Bugfix for correctly removing temporary file when cancelled. Bug: 714579 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4459f9a3b2e024ce6305f93a4c886600a81b73b6 Reviewed-on: https://chromium-review.googlesource.com/995243 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#548360} [modify] https://crrev.com/798c3cbb70fe157c1780ac3b613f8960647389a1/chrome/browser/resources/chromeos/zip_archiver/js/compressor.js |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by yawano@chromium.org
, Apr 24 2017Cc: mtomasz@chromium.org