New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714554 link

Starred by 4 users
Status: Verified
Owner:
dpa...@chromium.org
Closed: Apr 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Profile picture options are seen missing in chrome://md-settings/changePicture page

Project Member Reported by mmanchala@chromium.org, Apr 24 2017 
Chrome Version: 60.0.3077.0/9489.0.0 dev channel on Candy,Minnie and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Go to chrome://md-settings
(2)Now at 'People' section click on profile picture -> Navigates to chrome://md-settings/changePicture page and now observe
for Profile picture options  (Please refer Video and screenshot)

Expected: Profile picture options should be seen 
Actual: Instead Profile picture options are seen missing 

This is Regression issue as same is working fine in 59.0.3071.15/9460.5.0  dev-channel Daisy

@stevenjb : Please confirm the Issue

Note: Issue is working fine in old settings page(please refer 'ChangePicturePageInoldSettings' Attachment
Actual_ChangePicturePage.webm
823 KB View Download
Actual_ChangePicturePage.png
53.8 KB View Download
Expected_ChangePicturePage.webm
1.1 MB View Download
Expected_ChangePicturePage.png
286 KB View Download
ChangePicturePageInOldSettings.png
353 KB View Download

Comment 1 by steve...@chromium.org, Apr 24 2017

Cc: steve...@chromium.org
Owner: dpa...@chromium.org
This appears to have been caused by this CL:

https://codereview.chromium.org/2818163002

We access browser_Proxy_ in currentRouteChanged which appears to get called before attached() for SettingsChangePicture.

I suspect we need to move the initialization of browserProxy_ at least to ready().

We may run into this with other elements when moving initialization code.

Comment 2 by dpa...@chromium.org, Apr 24 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29374c5d9bb82e3bb15274d1e049785a1d785e68

commit 29374c5d9bb82e3bb15274d1e049785a1d785e68
Author: dpapad <dpapad@chromium.org>
Date: Mon Apr 24 19:17:44 2017

MD Settings: Fix initialization timing of browser proxy in change-picture.

BUG= 714554 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2841653002
Cr-Commit-Position: refs/heads/master@{#466710}

[modify] https://crrev.com/29374c5d9bb82e3bb15274d1e049785a1d785e68/chrome/browser/resources/settings/people_page/change_picture.js

Comment 4 by tbuck...@chromium.org, Apr 24 2017

Labels: Hotlist-MD-Settings-PeopleCrOS

Comment 5 by thuyamyo...@gmail.com, Apr 25 2017 

google play service

Comment 6 by dpa...@chromium.org, Apr 25 2017

Status: Fixed (was: Started)

Comment 7 by thuyamyo...@gmail.com, Apr 26 2017 

Sent from my sansumg device

google play service

Comment 8 by sdantul...@chromium.org, May 8 2017

Status: Verified (was: Fixed)
Verified on 9532.0.0, 60.0.3092.0
►

Sign in to add a comment