We're supporting mac OS 10.9 - 10.12. We should not rely on CoreText variations support in versions below 10.12. Use a hybrid stack with FreeType on those versions as well.
CL up in https://codereview.chromium.org/2842513004
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5 commit e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5 Author: drott <drott@chromium.org> Date: Thu Apr 27 05:44:22 2017 Move FreeType bundling on mac OS from PDFium up to Chrome Preparation for using FreeType on older mac OS versions for supporting OpenType variable fonts. Introduce a MAC_RESTRICT_VISIBILITY define in the FreeType build in order not to expose FreeType symbols on the main executable on Mac, since there is a symbol visibility check build-step which breaks if it finds FreeType symbols there. BUG= 714553 Review-Url: https://codereview.chromium.org/2842513004 Cr-Commit-Position: refs/heads/master@{#467593} [modify] https://crrev.com/e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5/DEPS [modify] https://crrev.com/e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5/build/config/freetype/BUILD.gn [modify] https://crrev.com/e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5/build_overrides/pdfium.gni [modify] https://crrev.com/e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5/third_party/freetype/BUILD.gn [modify] https://crrev.com/e30ecdc92de704ab362ed77b2c0c8ccb2553b3b5/third_party/freetype/include/freetype-custom-config/ftoption.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e commit 4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e Author: drott <drott@chromium.org> Date: Mon May 08 14:18:45 2017 Use FreeType for OpenType Variations on CoreText < 10.12 CoreText in versions older than Sierra has limited support for OpenType variations, for example it fails to pass GPOS tests with variation parameters applied. Use FreeType in those cases, similar to our approach on Windows. BUG= 714553 TEST=/fast/text/variable-fonts/* R=behdad, bungeman, eae Review-Url: https://codereview.chromium.org/2858573002 Cr-Commit-Position: refs/heads/master@{#469980} [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/skia/BUILD.gn [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/LayoutTests/NeverFixTests [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-gpos-m2b.html [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/LayoutTests/http/tests/webfont/variable-box-font-arraybuffer-expected.html [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/Source/platform/fonts/FontPlatformData.h [add] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/Source/platform/fonts/mac/CoreTextVariationsSupport.cpp [add] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/Source/platform/fonts/mac/CoreTextVariationsSupport.h [modify] https://crrev.com/4eaf7dfd6d9ce67d8b85b028af092f08b90ee39e/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
perhaps interesting also: https://bugs.chromium.org/p/pdfium/issues/detail?id=714
Comment 1 by drott@chromium.org
, Apr 24 2017