New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714548 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: 7
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

To fix bluetooth adapter autotests for bluez 5.44

Project Member Reported by josephsih@chromium.org, Apr 24 2017

Issue description

Bluez 5.44 has some different btmon log output format and error message. We need to fix our test code to adapt to the changes.

These changes are required to verify new kernels and bluez.
 
Cc: rjahagir@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8b62e18554351d90112f6a1e4426aa2a0efd2430

commit 8b62e18554351d90112f6a1e4426aa2a0efd2430
Author: Joseph Hwang <josephsih@chromium.org>
Date: Fri Apr 28 09:58:12 2017

bluetooth: fix advertising data format

When registering an advertisement, the value format and signatures of
ManufacturerData and ServiceData has been changed in bluez 5.44.

In addition, the btmon output format has been changed when adding
and removing advertisements.

This patch fixed the format change problem.

BUG= chromium:714548 
TEST=run the advertising test cases
(cros) $ test_that "${DUT_IP}" bluetooth_AdapterLEAdvertising.single
(cros) $ test_that "${DUT_IP}" bluetooth_AdapterLEAdvertising.multiple

Change-Id: Ie1967227cfd5b1aafb93f5066d0a3d02c1dadd97
Reviewed-on: https://chromium-review.googlesource.com/485540
Commit-Ready: Shyh-In Hwang <josephsih@chromium.org>
Tested-by: Shyh-In Hwang <josephsih@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/8b62e18554351d90112f6a1e4426aa2a0efd2430/client/cros/bluetooth/advertisement.py
[modify] https://crrev.com/8b62e18554351d90112f6a1e4426aa2a0efd2430/server/cros/bluetooth/bluetooth_adapter_tests.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/515a7df9f461f4f0de7c2e19d1a7b88fa28caf05

commit 515a7df9f461f4f0de7c2e19d1a7b88fa28caf05
Author: Joseph Hwang <josephsih@chromium.org>
Date: Fri Apr 28 09:58:12 2017

bluetooth: fix error message for "Failed to register advertisement"

The error message generated when registering more advertisements
than allowed has been changed in bluez 5.44. This patch fixed the
error message.

BUG= chromium:714548 
TEST=run the advertising test cases
(cros) $ test_that "${DUT_IP}" bluetooth_AdapterLEAdvertising.single
(cros) $ test_that "${DUT_IP}" bluetooth_AdapterLEAdvertising.multiple

Change-Id: Ie10c78f9f434c56b822809352a59222430ae75af
Reviewed-on: https://chromium-review.googlesource.com/485541
Commit-Ready: Shyh-In Hwang <josephsih@chromium.org>
Tested-by: Shyh-In Hwang <josephsih@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/515a7df9f461f4f0de7c2e19d1a7b88fa28caf05/server/cros/bluetooth/bluetooth_adapter_tests.py

Status: Verified (was: Started)

Sign in to add a comment