New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714525 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 715889



Sign in to add a comment

Regression: Cursor pin remains stuck at 'Enter custom web address' field even after tap/touch on New Tab page

Reported by sans...@etouch.net, Apr 24 2017

Issue description

Chrome Version: 60.0.3079.0 (Official Build)5d44f961b168a6cff0f822455b03cbca3eb44855-refs/heads/master@{#466571}(32/64 Bit).
OS: Windows 10 (Touch device)

Steps:
1. Launch Chrome and navigate to chrome://settings
2. Click/tap on Show home button, enter web address and tap on its text field (Cursor pin is seen)
3. Now tap/touch on New Tab page and observe

Actual: Cursor pin remains stuck at 'Enter custom web address' field after tap/touch on New Tab page

Expected: Cursor pin should vanish from 'Enter custom web address' field after tap/touch on New Tab page

This is regression issue broken in 'M 60' and below is bisect info:
Good Build 59.0.3071.0
Bad Build 60.0.3072.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/587d760ba800488146443dddbac5af049458ac51..6ea2f510147f3bca05aea7024752e95dcf559912?pretty=fuller&n=100

Suspecting: r464698 ?

Please help to re-assign if your change is not the cause for this issue.

Note: This is touch device specific issue, same works fine via mouse click.

 
Actual_video.mp4
692 KB View Download
Expected_video.mp4
397 KB View Download

Comment 1 by hu...@opera.com, Apr 25 2017

Cc: amaralp@chromium.org yosin@chromium.org dpa...@chromium.org
Owner: ----
Status: Available (was: Assigned)
I cannot explain this why this happens. The scenario reminds me of EventHandlerTest.ClearHandleAfterTap. amaralp@, do you know how to fix this? If not, let's revert my CL. (FYI @yosin).


Comment 2 by hu...@opera.com, Apr 25 2017

Owner: amaralp@chromium.org
I'm also not sure why this is happening. Actually this isn't specific to the radio button. If you tap in the margin of the page you see the same problem. I'd expect this to work the same way as the |EventHandlerTest.ClearHandleAfterTap| test so it's strange that the test passes but this is broken. I'll take a closer look tomorrow.

Comment 4 by hu...@opera.com, Apr 26 2017

Thanks amaralp@. Since this happens on touch events, maybe it is another symptom of http://crbug.com/683795 ?

Comment 5 by aelias@chromium.org, Apr 26 2017

Cc: aelias@chromium.org

Comment 6 by yosin@chromium.org, Apr 27 2017

Blocking: 715889

Comment 7 by yosin@chromium.org, Apr 27 2017

Status: Started (was: Available)
In review: http://crrev.com/2847663002
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/671e6334b0583671f907a52c23a1258b5e1d8770

commit 671e6334b0583671f907a52c23a1258b5e1d8770
Author: amaralp <amaralp@chromium.org>
Date: Wed May 17 07:34:58 2017

Don't show touch handles when selection hidden

If the selection is hidden then clear the touch handles.

Also changed IME test back to using radio input as it was prior to
crrev.com/2616623002. Tapping on a radio button is better to test focus change
because it doesn't create a selection. This means that the clearing of the
handle has to be done by the focus change and not because a new selection was
made.

BUG= 714525 

Review-Url: https://codereview.chromium.org/2847663002
Cr-Commit-Position: refs/heads/master@{#472371}

[modify] https://crrev.com/671e6334b0583671f907a52c23a1258b5e1d8770/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
[modify] https://crrev.com/671e6334b0583671f907a52c23a1258b5e1d8770/third_party/WebKit/Source/core/frame/FrameView.cpp

Comment 9 by yosin@chromium.org, May 19 2017

Status: Fixed (was: Started)

Comment 10 by sans...@etouch.net, May 23 2017

Note: Above issue is fixed on latest dev version 60.0.107.4, please refer the attached video
Fixed_video.mp4
502 KB View Download
Labels: TE-Verified-M60 TE-Verified-60.0.3107.4
As per Comment# 10, the issue is fixed on Latest Dev# 60.0.3107.4, hence adding TE-Verified Labels.
Thank You.

Sign in to add a comment