New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 594639



Sign in to add a comment

Crash when loading a module that previously failed to instantiate

Project Member Reported by kouhei@chromium.org, Apr 24 2017

Issue description

Originally reported by neis@

 

Comment 1 by kouhei@chromium.org, Apr 24 2017

Labels: -OS-Linux OS-All
Reported on github whatwg/html as
https://github.com/whatwg/html/issues/2556

Comment 2 by kouhei@chromium.org, Apr 24 2017

Cc: neis@chromium.org
Blink side fix + MTL unit test at https://codereview.chromium.org/2839563002/
neis: Would you mind writing a WPT test?
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/321b6ea1a1e2f392c629e2f074ae509a3aaefc42

commit 321b6ea1a1e2f392c629e2f074ae509a3aaefc42
Author: kouhei <kouhei@chromium.org>
Date: Fri Apr 28 03:57:48 2017

[ES6 modules] Return previous error when an instantiation is reattempt.

Before this CL, when instantiation was reattempt for previously errored module,
ModuleTreeLinker::Instantiate() crashed.

This CL updates the code to follow whatwg/html update:
https://github.com/whatwg/html/pull/2559
so that we rethrow previous error when instantiation is reattempt.
TEST=webkit_unit_test --gtest_filter=ModuleTreeLinkerTest.FetchTreePreviousInstantiationFailure
BUG= 594639 , 714521 

Review-Url: https://codereview.chromium.org/2839563002
Cr-Commit-Position: refs/heads/master@{#467882}

[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/dom/Modulator.h
[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/dom/ModulatorImpl.h
[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/dom/ModuleScript.h
[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp
[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/testing/DummyModulator.cpp
[modify] https://crrev.com/321b6ea1a1e2f392c629e2f074ae509a3aaefc42/third_party/WebKit/Source/core/testing/DummyModulator.h

Status: Fixed (was: Started)

Sign in to add a comment