New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714515 link

Starred by 2 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: May 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary focus ring is stays on 'Clear browsing data' link of chrome://history

Reported by db...@etouch.net, Apr 24 2017 
Chrome Version: 60.0.3079.0 (Official Build) (64-bit) (cohort: win_58_81)5d44f961b168a6cff0f822455b03cbca3eb44855-refs/heads/master@{#466571}(32/64 Bit).
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://history page.
(2) Click on Clear browsing data(it will navigate to chrome://settings/clearBrowserData page )
(3) Come back to chrome://history page and observe.

Actual: Unnecessary focus ring is stays on 'Clear browsing data' link after clicking on it.

Expected: Focus ring should not stays on 'Clear browsing data' link.

This is a Regression issue broken in M-60, will soon update other info

Good build: 60.0.3074.0 
Bad build: 60.0.3076.0
Actual_History.mp4
209 KB View Download
Expected_History.mp4
137 KB View Download

Comment 1 by msrchandra@chromium.org, Apr 24 2017

Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 60.0.3074.0 (Revision: 465085).
Bad build : 60.0.3076.0 (Revision: 465838).

You are probably looking for a change made after 465153 (known good), but no later than 465154 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/3c24f4f7064cb6fcf8827bd5bd29ec12664dbd3d..dcf200334b52ac07d81baaec5257e4a964fa3137

@tsergeant: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.

Comment 2 by tsergeant@chromium.org, May 9 2017

Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
This is minor, but an easy fix.
Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e4017253ecba8c9745dff3b363b63e4781cd4ef

commit 8e4017253ecba8c9745dff3b363b63e4781cd4ef
Author: tsergeant <tsergeant@chromium.org>
Date: Wed May 10 04:43:03 2017

MD History: Prevent focus ring when clicking on 'Clear Browsing Data'

Setting tabindex="" on this link restores the default <a> behavior,
which shows a focus ring on keyboard focus but not on click.

BUG= 714515 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873563002
Cr-Commit-Position: refs/heads/master@{#470453}

[modify] https://crrev.com/8e4017253ecba8c9745dff3b363b63e4781cd4ef/chrome/browser/resources/md_history/side_bar.js

Comment 4 by tsergeant@chromium.org, May 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment