New issue
Advanced search Search tips

Issue 714511 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Task

Blocking:
issue 694138



Sign in to add a comment

Web MIDI: enable dynamic instantiation mode by default

Project Member Reported by toyoshim@chromium.org, Apr 24 2017

Issue description

No the experimental feature is going to be launched via experiment-controlled rollouts.

To finish this launch process, I will flip the flag to enable the feature by default on ToT, and will merge it to other release branches.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3793199ef338f7a3f19ba5d6d35ceb8ba63c8f33

commit 3793199ef338f7a3f19ba5d6d35ceb8ba63c8f33
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Apr 25 05:20:29 2017

Web MIDI dynamic instantiation experiment-controlled rollouts: step 4

Enable dynamic instantiation mode by default on Linux, ChromeOS,
and Windows. Other platforms still need to rely on the existing
experiment-controlled flag and will be launched separately.

BUG=672793, 714511 

Review-Url: https://codereview.chromium.org/2835083002
Cr-Commit-Position: refs/heads/master@{#466881}

[modify] https://crrev.com/3793199ef338f7a3f19ba5d6d35ceb8ba63c8f33/media/midi/midi_service.cc

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/814d90a45d7608581b0e70e52abb964e713a6dba

commit 814d90a45d7608581b0e70e52abb964e713a6dba
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Apr 26 07:33:07 2017

Web MIDI dynamic instantiation experiment-controlled rollouts: step 4

Enable dynamic instantiation mode by default on Linux, ChromeOS,
and Windows. Other platforms still need to rely on the existing
experiment-controlled flag and will be launched separately.

BUG=672793, 714511 
TBR=yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2835083002
Cr-Commit-Position: refs/heads/master@{#466881}
(cherry picked from commit 3793199ef338f7a3f19ba5d6d35ceb8ba63c8f33)

Review-Url: https://codereview.chromium.org/2842963002 .
Cr-Commit-Position: refs/branch-heads/3071@{#218}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/814d90a45d7608581b0e70e52abb964e713a6dba/media/midi/midi_service.cc

Status: Fixed (was: Started)

Sign in to add a comment