Regression: Sign in button appears small on chrome://history/syncedTabs
Reported by
aiman.an...@etouch.net,
Apr 24 2017
|
||||
Issue descriptionChrome Version: 60.0.3079.0 (Official Build) (64-bit) (cohort: win_58_81)5d44f961b168a6cff0f822455b03cbca3eb44855-refs/heads/master@{#466571}(32/64 Bit). OS: Windows(7,8,10). Steps to reproduce: 1.Launch Chrome, go to chrome://history/syncedTabs and observe the Sign In button. Actual Result: Sign in Button appears small. Expected Result: Sign In Button Should appear normal This is regression issue broken in 'M 60' and will soon update the bisect info: Manual Bisect Info: Good Build 60.0.3078.0 Bad Build 60.0.3079.0
,
Apr 24 2017
Manual Bisect: -------------- Good Build 60.0.3078.0-(Revision-466494) Bad Build 60.0.3079.0-(Revision-466571) Per revision bisect Tool Info: ------------------------------ https://chromium.googlesource.com/chromium/src/+log/63128d6f67866fb126cc8043b6a4400133a67d4b..32d9f5075ba7f767d2c6c6d41794dc70b5ff7bf3 Review-Url: https://codereview.chromium.org/2831963004 sammiequon@ Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change. Thanks.!
,
May 9 2017
Gentle ping to sammiequon@.
,
May 10 2017
This was caused by changing the setup pin dialog ok & confirm buttons padding and we decided to make it settings-wide for consistency. tbuckley@ - are we ok with this for md-history.
,
May 10 2017
Though that button looks very squashed, perhaps we should revert and look at a different approach.
,
May 10 2017
@sammiequon agreed it looks broken, we should use the old button style. Where in the PIN flow do we have buttons with no padding? The "Expected Result" image above is what buttons should look like across all of MD Settings / History / etc.
,
May 10 2017
This should be fixed by https://codereview.chromium.org/2837763002
,
May 12 2017
Marking as Fixed per comment #7 (the button also looks normal to me on the latest Mac Canary). Feel free to re-open if there's more work to be done here. |
||||
►
Sign in to add a comment |
||||
Comment 1 by aiman.an...@etouch.net
, Apr 24 2017