New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714484 link

Starred by 1 user
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Apr 2017
Cc:
█ mgiuca@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

#bypass-app-banner-engagement-checks is broken on page load

Project Member Reported by mgiuca@chromium.org, Apr 24 2017 
Chrome Version: 59 (r463480)
OS: Android

What steps will reproduce the problem?
(1) Turn on #bypass-app-banner-engagement-checks
(2) Visit a PWA (https://www.progressivewebflap.com/)

What is the expected result?
Should immediately see an install banner.

What happens instead?
You don't. But you do get one if you perform a user gesture after 10s.

This seems to have regressed recently. I don't think it's a problem in 58.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64c866e4041adcf57e6e86438482b2c030151f0d

commit 64c866e4041adcf57e6e86438482b2c030151f0d
Author: dominickn <dominickn@chromium.org>
Date: Mon Apr 24 06:05:38 2017

Fix the ability to bypass app banner engagement checks.

Following https://crrev.com/2778983005, the
chrome://flags/#bypass-app-banner-engagement-checks flag now does not
work unless there is an engagement increase to above the engagement
threshold. This is due to an oversight where the case of the flag being
turned on could trigger the banner pipeline, but was treated like the on
load installability experiment immediately prior to sending the
beforeinstallprompt event.

This CL fixes the bug by explicitly setting |has_sufficient_engagement_|
to true if the bypass flag is enabled (or if 0 engagement is required
for the banner to show).

BUG= 714484 

Review-Url: https://codereview.chromium.org/2833313002
Cr-Commit-Position: refs/heads/master@{#466590}

[modify] https://crrev.com/64c866e4041adcf57e6e86438482b2c030151f0d/chrome/browser/banners/app_banner_manager.cc

Comment 2 by mgiuca@chromium.org, Apr 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment