Cannot find inner editor under INPUT after UA shadow DOM tampered by TestRunner |
||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5056727658790912 Fuzzer: inferno_layout_test_unmodified Job Type: mac_asan_content_shell Platform Id: mac Crash Type: UNKNOWN READ Crash Address: 0x000000000010 Crash State: blink::Node::CanParticipateInFlatTree blink::Document::NeedsLayoutTreeUpdateForNode blink::Document::UpdateStyleAndLayoutTreeForNode Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=447544:447851 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5056727658790912 Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Apr 24 2017
,
Apr 24 2017
This can be a duplicated of bug #688218 , but I never managed to reproduce it so I don't know. Regarding this new bug report I cannot reproduce this issue on Linux. I'll try to find some time to test it on Mac too. I guess using a pre-built binary from https://commondatastorage.googleapis.com/chromium-browser-asan/index.html should be valid to reproduce the problem. Am I missing something?
,
Apr 24 2017
Can repro on Linux with content_shell and --run-layout-test flag. The crash is due to tampering the id of the inner editor of an INPUT, making TextControlElement::InnerEditorElement() return null, resulting a nullptr deref. I don't think this is really a bug -- only TestRunner has the power to tamper a UA shadom DOM with JavaScript, and any code using TestRunner is considered testing code. Can we stop ClusterFuzz from generating incorrect testing code?
,
Apr 25 2017
Thanks @xiaochengh I can reproduce it now with "--run-layout-test" too. I'm attaching a reduced test case, but the issue is basically what @xiaochengh described. So I guess we can close this as "Won't Fix".
,
May 12 2017
,
May 26 2017
,
May 27 2017
ClusterFuzz has detected this issue as fixed in range 474922:474938. Detailed report: https://clusterfuzz.com/testcase?key=5056727658790912 Fuzzer: inferno_layout_test_unmodified Job Type: mac_asan_content_shell Platform Id: mac Crash Type: Null-dereference READ Crash Address: 0x000000000010 Crash State: blink::Node::CanParticipateInFlatTree blink::Document::NeedsLayoutTreeUpdateForNode blink::Document::UpdateStyleAndLayoutTreeForNode Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=447544:447851 Fixed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=474922:474938 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5056727658790912 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msrchandra@chromium.org
, Apr 24 2017Components: Blink>Editing
Labels: Test-Predator-Correct-CLs M-58
Owner: r...@chromium.org
Status: Assigned (was: Untriaged)