New issue
Advanced search Search tips

Issue 714412 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Linux build failure on master branch

Reported by samueldo...@gmail.com, Apr 22 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.81 Safari/537.36

Steps to reproduce the problem:
git checkout -f master
gclient runhooks
git rebase-update                                                                                                                                         
gclient sync
ninja -t clean
gn gen out/Default

cat > out/Default/args.gn << EOF
google_api_key = ...
google_default_client_id = ...
google_default_client_secret = ...
target_cpu = "x64"
is_debug = false
is_component_build = false
symbol_level = 0
enable_nacl = false
remove_webcore_debug_symbols = true
linux_use_bundled_binutils=false
use_debug_fission=false
is_clang=false
use_sysroot=false
treat_warnings_as_errors=false
EOF

ninja -C out/Default chrome

What is the expected behavior?
Build completes with a successful link of Chromius

What went wrong?
[7930/25688] CXX obj/third_party/swiftshader/src/Main/swiftshader_main/FrameBuffer.o
FAILED: obj/third_party/swiftshader/src/Main/swiftshader_main/FrameBuffer.o 
g++ -MMD -MF obj/third_party/swiftshader/src/Main/swiftshader_main/FrameBuffer.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DDISABLE_NACL -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DLOG_TAG=\"swiftshader_main\" -I../../third_party/swiftshader/src -I../../third_party/swiftshader/src/Common -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -m64 -march=x86-64 -pthread -Wall -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g0 -fvisibility=hidden -msse2 -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -fno-rtti -fno-exceptions -c ../../third_party/swiftshader/src/Main/FrameBuffer.cpp -o obj/third_party/swiftshader/src/Main/swiftshader_main/FrameBuffer.o
In file included from ../../third_party/swiftshader/src/Common/Resource.hpp:18:0,
                 from ../../third_party/swiftshader/src/Renderer/Surface.hpp:20,
                 from ../../third_party/swiftshader/src/Main/FrameBuffer.hpp:19,
                 from ../../third_party/swiftshader/src/Main/FrameBuffer.cpp:15:
../../third_party/swiftshader/src/Common/MutexLock.hpp:167:22: error: member ‘std::atomic<bool> sw::BackoffLock::<anonymous struct>::mutex’ with constructor not allowed in anonymous aggregate
    std::atomic<bool> mutex;
                      ^

Did this work before? Yes I had built Chromium just a few days back on the same system using the same steps

Chrome version: 58.0.3029.81  Channel: dev
OS Version: 
Flash Version: Shockwave Flash 25.0 r0

cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.2 LTS"

uname -r
4.4.0-72-generic

System fully updated with latest available packages
 
Note, I reported this on a Chrome beta build so default information was picked up from that seeing Chromium no longer works for me.
Components: Build
Labels: Build-failure
The above bug relates to Build failure, so adding Build component for further triaging.
Cc: thomasanderson@chromium.org capn@chromium.org
+capn Looks like the gcc build is broken again :(

Comment 4 by capn@chromium.org, Apr 28 2017

Owner: capn@chromium.org
Status: Started (was: Unconfirmed)
I got this.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28867910b5b95627028a0f1c6a60f3982f7a5e83

commit 28867910b5b95627028a0f1c6a60f3982f7a5e83
Author: capn <capn@chromium.org>
Date: Fri Apr 28 22:14:09 2017

Roll SwiftShader dc7759c..35e0ba7

https://swiftshader.googlesource.com/SwiftShader.git/+log/dc7759c..35e0ba7
Use pthread mutexes on Linux instead of custom spin lock.
Fixes compilation issue.

BUG= chromium:714412 

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2850843002
Cr-Commit-Position: refs/heads/master@{#468153}

[modify] https://crrev.com/28867910b5b95627028a0f1c6a60f3982f7a5e83/DEPS

Status: Fixed (was: Started)
Confirmed with build from 060d293f1d87d450a824dc46f564792272ed34a3

Sign in to add a comment