New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714407 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Regression: The Bookmarks Bar is janky when you start Canary

Project Member Reported by meh...@chromium.org, Apr 22 2017

Issue description

Chrome Version: Chrome Canary Version 60.0.3078.0 
OS: MacOS 10.12.4

What steps will reproduce the problem?
(1) Start Chrome.
(2) The Chrome Window opens.
(3) Take a look at the Bookmarks Bar.

What is the expected result?
The content of the Bookmarks bar should not appear with a janky animation.

What happens instead?
The content of the Bookmarks Bar appears with a janky animation.

Please use labels and text to provide additional information.
A screencast is attached: The first window is Chrome Stable 58. The second window is Chrome Canary 60. You'll notice that the content of the Bookmarks bar appear with a janky animation.

This is a regression. If you need more information please let me know.

Thanks!
 
bug.mov
804 KB Download

Comment 1 by shrike@chromium.org, Apr 24 2017

Cc: shrike@chromium.org
Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
Do you mean how the bar's contents drop down into place (show near the end of your screencast)?

Comment 2 by meh...@chromium.org, Apr 24 2017

Yes, exactly. That's what I mean. Thanks. 
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Mac 10.12.4 using chrome reported version-60.0.3078.0 , stable-58.0.3029.81  & Canary-60.0.3083.0 as per the below steps:
1. Changed system language to German
2. Ensure no other chrome windows should be in open mode
3. Launch new chrome (stable)   
4. Observed the 'bookmark bar' with junky animation for a new tab
5. Close chrome window
6. Quit chrome (CMD + Q)
7. Launch new chrome (Canary)  
8. Also Observed the 'bookmark bar' with junky animation for a new tab

Note:
We can observe 'Bookmark bar without junky animation' as per below steps:
1. Launch chrome once
2. just close the chrome window
3. Do not click Cmd+Q
4. Now again launch chrome by clicking on chrome icon

Please find the attached screencast for reference & let us know if we miss any steps to reproduce the issue.
Thank you..!!



714407.mp4
567 KB View Download

Comment 4 by meh...@chromium.org, Apr 28 2017

Labels: -Needs-Feedback
Hm... thats is strange. I am still able to reproduce the issue with latest Canary, also with a clean profile. I am using a Non-Retina MacBook Air (Mid 2012). But I don't think that this could be a screen resolution issue?!

A further screencast is attached.
screencast.mov
5.0 MB Download
Labels: -Needs-Bisect -Type-Bug-Regression M-60 Type-Bug
mehmet@,
Thanks for the reply.
Able to reproduce the issue on Mac 10.12.4 using chrome reported version-60.0.3078.0 , stable-58.0.3029.81 on Mac book Air  & Canary-60.0.3083.0 as per comment#4 screencast.

Observed 'content of the Bookmarks Bar appears with a janky animation' when we open chrome for the first time(no other chrome windows should be in open mode).

Observed the same behavior from M35 builds & confirming this issue to get more inputs from dev team.

Please find the attached screencast fro reference.
Thank you..!!
714407-Mac.mp4
798 KB View Download
jmukthavaram@: Thanks for checking it, but I don't mean the Bookmarks Bar itself. As shrike@ mentioned in comment 1, I mean the animation of the content of the bar (text, bookmarks) that is dropping down into place. That animation is differing between Stable and Canary Build. Thanks.
Something changed here in latest Canary 60.0.3091.0.:

The "dropping down" issue seems to be fixed. But now when you start Canary, the "Import Bookmarks" text is to see for a second, before all bookmarks and folder appear on the Bar.

A screencast is attached.

+ screencast
screencast.mov
819 KB Download

Comment 9 by lgrey@chromium.org, May 8 2017

mehmet@ what are your machine's specs? 

I haven't been able to repro either this issue or the one from earlier in this bug, and I'm wondering if there's some sort of hardware difference that's causing the bar to come in slower.
Hello lgrey@, I am using a MacBook Air 11" Mid 2012 and a iMac 21,5 End 2012. Both have NonRetina Displays. I am seeing it on both machines.

I am wondering, because it doesn't happen in latest Stable.

Enclosed a screencast Stable vs. Canary.

Thanks for looking into it.
Stable_vs_Canary.mov
2.4 MB Download
Project Member

Comment 11 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/777cb457cb9989f53d135239d36196a41835b6a9

commit 777cb457cb9989f53d135239d36196a41835b6a9
Author: lgrey <lgrey@chromium.org>
Date: Tue May 09 17:34:52 2017

[Mac] Hide bookmark bar empty view by default

This is a speculative fix for  crbug.com/714407 ,
specifically the post-refactor manifestation in #10. Speculative
because I can't repro.

BUG= 714407 

Review-Url: https://codereview.chromium.org/2867823002
Cr-Commit-Position: refs/heads/master@{#470367}

[modify] https://crrev.com/777cb457cb9989f53d135239d36196a41835b6a9/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm

Comment 12 by lgrey@chromium.org, May 10 2017

mehmet@ is this fixed now?
Hello lgrey@,

Yes, thank you. It is fixed in latest Canary Version 60.0.3095.0. The "Import Bookmarks" text is no longer to see, before all bookmarks and folder appear on the Bar.

But the initial "dropping down" issue is now in Beta (M59). What do you think, should we leave it as it is in M59, because we do not know what could have fixed it?

Comment 14 by lgrey@chromium.org, May 10 2017

I know how to simulate the issue now, so I could theoretically get an older checkout and maybe come up with something that could be cherry-picked to M59. My feeling is it's probably not worth it. shrike@ what do you think?
Seems like the change is small, so cherry-picking back to M59 is not super risky. If you can check out M59 and reproduce the problem and confirm your cherry pick fixes it there it's probably worth it.

Comment 16 by lgrey@chromium.org, May 10 2017

shrike@ to be clear this would be a different fix. The original issue was (I think) fallout from NIB removal, this fix relies on the new layout code to do its thing.
Labels: Needs-Feedback
Tested this issue on Mac-10.12.4 using chrome version 60.0.3095.5 as per comment#13.
Issue 1-> The  "Import Bookmarks" text is no longer to see, before all bookmarks and folder appear on the Bar.
Observed this issue got fixed.

 Issue 2 ->Bookmarks bar droping down janky issue.
Still issue observed.

Please find the attached screencasts of both fixed(Issue 1) &  issue 2  behavior.

Thanks.

714407.mp4
663 KB View Download
714407-issue.mp4
1.1 MB View Download
Cc: sureshkumari@chromium.org

Comment 19 by lgrey@chromium.org, May 11 2017

Can we split the non-regression into a separate bug? I'd like to look at it eventually since views has a smooth animation instead of it popping in and out, but I don't think it's a P1 or related to the issue mehmet@ brought up.

shrike@ ping re: #16
lgrey@ - I'm confused on what's what here (sorry). We can discuss on Monday, or set up a GVC for this week if that's too long to wait.
Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment