New issue
Advanced search Search tips

Issue 714386 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

User-preferred audio device in content settings is not preferred over default device

Project Member Reported by guidou@chromium.org, Apr 22 2017

Issue description

This is a regression in the current M59.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18633fc39ce832de0cea59a4c7f4371144c407e0

commit 18633fc39ce832de0cea59a4c7f4371144c407e0
Author: guidou <guidou@chromium.org>
Date: Sat Apr 22 19:27:57 2017

Revert of Initialize default audio device ID with explicit device ID. (patchset #4 id:170001 of https://codereview.chromium.org/2809043004/ )

Reason for revert:
Causes  http://crbug.com/714386 

Original issue's description:
> Reland of Initialize default audio device ID with explicit device ID. (patchset #1 id:1 of https://codereview.chromium.org/2813543005/ )
>
> Reason for revert:
> Will attempt to reland by reverting changes in MSM and updating extensions test.
>
> Original issue's description:
> > Revert of Initialize default audio device ID with explicit device ID. (patchset #2 id:20001 of https://codereview.chromium.org/2812903002/ )
> >
> > Reason for revert:
> > Patchset 2 restores the behavior I wanted to eliminate.
> >
> > Original issue's description:
> > > Initialize default audio device ID with explicit device ID.
> > >
> > > This is more consistent with how video device IDs are specified and is
> > > also a small first step towards implementing the standard constraints
> > > algorithm for audio.
> > > This CL disables a misleading selector that allows switching the
> > > user-preferred device in the middle of a getUserMedia call.
> > > Since that selector does not affect the current getUserMedia call, it
> > > is better to have it disabled, which is already the case with video
> > > devices.
> > >
> > > BUG= 708081 
> > >
> > > Review-Url: https://codereview.chromium.org/2812903002
> > > Cr-Commit-Position: refs/heads/master@{#463624}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d
> >
> > TBR=hbos@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= 708081 
> >
> > Review-Url: https://codereview.chromium.org/2813543005
> > Cr-Commit-Position: refs/heads/master@{#463634}
> > Committed: https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72
>
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 708081 
>
> Review-Url: https://codereview.chromium.org/2809043004
> Cr-Commit-Position: refs/heads/master@{#463710}
> Committed: https://chromium.googlesource.com/chromium/src/+/be26518ed4e8a2966c919a93b488689374b17d42

TBR=mek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 708081 , 714386 

Review-Url: https://codereview.chromium.org/2829403002
Cr-Commit-Position: refs/heads/master@{#466550}

[modify] https://crrev.com/18633fc39ce832de0cea59a4c7f4371144c407e0/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/18633fc39ce832de0cea59a4c7f4371144c407e0/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/18633fc39ce832de0cea59a4c7f4371144c407e0/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc

Comment 2 by guidou@chromium.org, Apr 22 2017

Labels: Merge-Request-59

Comment 3 by guidou@chromium.org, Apr 22 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 23 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by guidou@chromium.org, Apr 24 2017

Note that I want to merge the revert, which should be a clean merge.
This was a small fix for another problem, but the regression it caused is worse than the bug that got fixed.

Comment 6 by gov...@chromium.org, Apr 24 2017

Approving merge to M59 branch 3071 based on comment #5. Please merge ASAP. Thank you.

Comment 7 by gov...@chromium.org, Apr 24 2017

Labels: -Merge-Review-59 Merge-Approved-59
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 25 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7111ba056d63c43cc30745302e12ff31d0cc17

commit 4f7111ba056d63c43cc30745302e12ff31d0cc17
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Apr 25 08:32:03 2017

Revert of Initialize default audio device ID with explicit device ID. (patchset #4 id:170001 of https://codereview.chromium.org/2809043004/ )

Reason for revert:
Causes  http://crbug.com/714386 

Original issue's description:
> Reland of Initialize default audio device ID with explicit device ID. (patchset #1 id:1 of https://codereview.chromium.org/2813543005/ )
>
> Reason for revert:
> Will attempt to reland by reverting changes in MSM and updating extensions test.
>
> Original issue's description:
> > Revert of Initialize default audio device ID with explicit device ID. (patchset #2 id:20001 of https://codereview.chromium.org/2812903002/ )
> >
> > Reason for revert:
> > Patchset 2 restores the behavior I wanted to eliminate.
> >
> > Original issue's description:
> > > Initialize default audio device ID with explicit device ID.
> > >
> > > This is more consistent with how video device IDs are specified and is
> > > also a small first step towards implementing the standard constraints
> > > algorithm for audio.
> > > This CL disables a misleading selector that allows switching the
> > > user-preferred device in the middle of a getUserMedia call.
> > > Since that selector does not affect the current getUserMedia call, it
> > > is better to have it disabled, which is already the case with video
> > > devices.
> > >
> > > BUG= 708081 
> > >
> > > Review-Url: https://codereview.chromium.org/2812903002
> > > Cr-Commit-Position: refs/heads/master@{#463624}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d
> >
> > TBR=hbos@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG= 708081 
> >
> > Review-Url: https://codereview.chromium.org/2813543005
> > Cr-Commit-Position: refs/heads/master@{#463634}
> > Committed: https://chromium.googlesource.com/chromium/src/+/cf8ea8d590f1c89c2633c793a41bd31a85b3fe72
>
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 708081 
>
> Review-Url: https://codereview.chromium.org/2809043004
> Cr-Commit-Position: refs/heads/master@{#463710}
> Committed: https://chromium.googlesource.com/chromium/src/+/be26518ed4e8a2966c919a93b488689374b17d42

TBR=mek@chromium.org
BUG= 708081 , 714386 

Review-Url: https://codereview.chromium.org/2829403002
Cr-Commit-Position: refs/heads/master@{#466550}
(cherry picked from commit 18633fc39ce832de0cea59a4c7f4371144c407e0)

Review-Url: https://codereview.chromium.org/2837873004 .
Cr-Commit-Position: refs/branch-heads/3071@{#194}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/4f7111ba056d63c43cc30745302e12ff31d0cc17/content/renderer/media/user_media_client_impl.cc
[modify] https://crrev.com/4f7111ba056d63c43cc30745302e12ff31d0cc17/content/renderer/media/user_media_client_impl_unittest.cc
[modify] https://crrev.com/4f7111ba056d63c43cc30745302e12ff31d0cc17/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc

Status: Verified (was: Fixed)
Tested Ok. 

Bug is no longer exists using Chrome M60 60.0.3081.0/canary on Windows 10 and Linux Ubuntu 14.04  (not tested on mac because no M60 chrome canary release was available)

Sign in to add a comment