New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714379 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 732656



Sign in to add a comment

Consider not sending the LocalSurfaceId with every CompositorFrame

Project Member Reported by fsam...@chromium.org, Apr 22 2017

Issue description

A (Local)SurfaceId is effectively a sync point for CompositorFrames to allow multiple clients to align streams of frames.

However, today we send a LocalSurfaceId with every single CompositorFrame.

This seems unnecessary. We probably only need to send a LocalSurfaceId with/before a CompositorFrame when we need to insert a "sync point" in the CompositorFrame stream. We should consider changing the API for LocalSurfaceId to be more "sync point" / "fence" like by only sending a new LocalSurfaceId when needed.
 
Two possible complications are when the gpu process crashes in the future when the display compositor moves there or when we evict frames.

Comment 2 by danakj@chromium.org, Apr 25 2017

What's the benefit of the proposal?
1. A possibly simplified API: Only need to submit a CompositorFrame without attaching a LocalSurfaceId.

2. Fewer bits to serialize / deserialize with simple CompositorFrames but this probably insignificant compared to the size of the CompositorFrame.

I see the main advantage being a simpler API, really. With the current API, a client could (ab)use SubmitCompositorFrame to ping-pong between two different LocalSurfaceIds, for example. An API that explicitly exposes LocalSurfaceId as a synchronization primitive would less likely be misused. This is by no means a priority, but just an observation.
Cc: weiliangc@chromium.org
Cc: varkha@chromium.org

Comment 6 by danakj@chromium.org, Jun 12 2017

Blocking: -601863
This sounds like a subidea of the general idea of CompositorFrame deltas instead of sending the full state every frame.
Blocking: 732656
Components: -Internals>MUS
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 14 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
Fady to triage please.
Cc: moh...@chromium.org fsam...@chromium.org
Owner: moh...@chromium.org
I think this is still a nice to have. Assigning to mohsen@ if he wishes to pick it up at some point. 

Sign in to add a comment