New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714375 link

Starred by 2 users
Status: Fixed
Owner:
█ deadbeef@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chrome://webrtc-internals is displaying internal names of enums in event log

Project Member Reported by deadbeef@chromium.org, Apr 22 2017 
For example, "kSignalingStateStable", instead of "stable" as previously displayed.

This happened due to the Blink Rename. An enum was being converted to a string using a macro, which was manually kept in sync with a dictionary in a JS file somewhere else. So, understandably, the rename script didn't catch this.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4604d257703df68c8865db1a5d27f3059c2920

commit fb4604d257703df68c8865db1a5d27f3059c2920
Author: deadbeef <deadbeef@chromium.org>
Date: Wed Apr 26 08:26:47 2017

Fixing some strings that go into webrtc-internals.

Mainly, some enums were being displayed in their raw form, due to the
Blink Rename. For example, "kSignalingStateStable" instead of "stable".

BUG= chromium:714375 

Review-Url: https://codereview.chromium.org/2832263004
Cr-Commit-Position: refs/heads/master@{#467267}

[modify] https://crrev.com/fb4604d257703df68c8865db1a5d27f3059c2920/content/renderer/media/peer_connection_tracker.cc

Comment 2 by deadbeef@chromium.org, Apr 26 2017

Status: Fixed (was: Started)

Comment 3 by fi...@appear.in, Jun 8 2017 

I just saw the ice connection states being broken in M59. Should I investigate?

Comment 4 by deadbeef@chromium.org, Jun 8 2017 

I think that's just because the blink rename happened before M59 branched, and I fixed this afterwards. It may be too late to merge now, but at least the issue is only cosmetic.

Comment 5 by fi...@appear.in, Jun 8 2017 

phew. Thanks, I don't consider it anything but cosmetic either!
►

Sign in to add a comment