New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714353 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Crash in blink::V8AbstractEventListener::BelongsToTheCurrentWorld

Project Member Reported by ClusterFuzz, Apr 22 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5573787967029248

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0x00000000
Crash State:
  blink::V8AbstractEventListener::BelongsToTheCurrentWorld
  blink::EventTarget::GetAttributeEventListener
  blink::EventTarget::ClearAttributeEventListener
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=435133:435159

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5573787967029248


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>JavaScript
Labels: Test-Predator-Wrong M-58
Components: -Blink>JavaScript Blink
Not a V8 issue.
Components: -Blink Blink>Input
Labels: Hotlist-Input-Dev
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Cc: dominicc@chromium.org
The ExecutionContext is null.

dominicc@ when do we expect to see a null execution context on a Node? Shouldn't it always have an associated document?
This looks like an interesting crash. Nodes should have owner documents, but this has adoption which changes documents.

Is this flaky or can you simply bisect the regression range?
It is certainly reproducible and I can debug it... I just am not certain where to look. If you download the test case it fails in 58 as well.. I can try a bisect tomorrow if you think it will help.
Cc: dtapu...@chromium.org
Labels: -Type-Bug Type-Bug-Regression
Owner: sigbjo...@opera.com
Ah, so CF's regression range is wrong. I bisected it to this:

https://chromium.googlesource.com/chromium/src/+/05c2d71f2c3cab4c40c3d775b304d0bbfbd166bd

sigbjornf, PTAL.

Here's a repro.
cr714353.html
161 bytes View Download
Status: Started (was: Assigned)
Thanks very much dominicc@, a pinpoint bisect _and_ a repro testcase :) We need to adjust where this probing for being in a document parsing state happens, so as to handle the frame-detached case better, I think.
Project Member

Comment 11 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c689934871ad2f934d37938b67e7a3fb2b65987

commit 3c689934871ad2f934d37938b67e7a3fb2b65987
Author: sigbjornf <sigbjornf@opera.com>
Date: Mon May 01 05:55:04 2017

Fix detached event listener attribute updating.

The parser will in some cases create new elements in documents that
have become frame-detached. Account for that -- no execution context
due to the document having become detached -- when processing the
event listeners of an event attribute.

R=haraken
BUG= 714353 

Review-Url: https://codereview.chromium.org/2855443002
Cr-Commit-Position: refs/heads/master@{#468294}

[add] https://crrev.com/3c689934871ad2f934d37938b67e7a3fb2b65987/third_party/WebKit/LayoutTests/fast/events/event-listener-detached.html
[modify] https://crrev.com/3c689934871ad2f934d37938b67e7a3fb2b65987/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Status: Fixed (was: Started)
Project Member

Comment 13 by ClusterFuzz, May 1 2017

ClusterFuzz has detected this issue as fixed in range 468288:468304.

Detailed report: https://clusterfuzz.com/testcase?key=5573787967029248

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0x00000000
Crash State:
  blink::V8AbstractEventListener::BelongsToTheCurrentWorld
  blink::EventTarget::GetAttributeEventListener
  blink::EventTarget::ClearAttributeEventListener
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=435133:435159
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=468288:468304

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5573787967029248


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Cc: sigbjo...@opera.com haraken@chromium.org
 Issue 717005  has been merged into this issue.
Project Member

Comment 15 by ClusterFuzz, May 2 2017

Labels: OS-Mac

Sign in to add a comment