New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714352 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[MD settings] The Change button is too narrow

Project Member Reported by dschuyler@chromium.org, Apr 22 2017

Issue description

In chrome://settings in the Downloads section there is a CHANGE button.
That button doesn't have the same side padding and placement of other buttons like it because this button is a Controlled button.
 
Labels: Hotlist-MD-Settings-Downloads OS-All

Comment 2 Deleted

Before and after screen shots (the one with wider spacing is the after)
Screenshot from 2017-05-08 16:28:04.png
1.1 KB View Download
Screenshot from 2017-05-08 16:25:25.png
1.1 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bff7fbab75d3308f3901a198853373638b8efcee

commit bff7fbab75d3308f3901a198853373638b8efcee
Author: dschuyler <dschuyler@chromium.org>
Date: Wed May 10 18:26:57 2017

[MD settings] set margins on change download location button

This CL sets the padding/margin on buttons so that there is 12px on either
side of the button label text (per UI design).

BUG= 714352 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2870773002
Cr-Commit-Position: refs/heads/master@{#470650}

[modify] https://crrev.com/bff7fbab75d3308f3901a198853373638b8efcee/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/bff7fbab75d3308f3901a198853373638b8efcee/chrome/browser/resources/settings/settings_vars_css.html

Status: Fixed (was: Started)

Sign in to add a comment