MD Settings; Exiting a subpage should restore focus to the subpage trigger (arrow icon), CrOS |
|||||||
Issue descriptionThis is similar to issue 709586 , but only tracking the remaining CrOS cases. Pasting below from https://bugs.chromium.org/p/chromium/issues/detail?id=709586#c14 The only remaining cases I am aware of are for CrOS, specifically: printing_page/printing_page.html (cups printer details sub-subpage) bluetooth_page/bluetooth_page.html internet_page/internet_page.html
,
Apr 25 2017
printing_page was added in https://codereview.chromium.org/2811693004. Working on internet and bluetooth.
,
Apr 25 2017
CL https://codereview.chromium.org/2811693004 only partially addressed the printing_page.html. See CL description, especially the part that says " printing_page (except CUPS printer sub-sub page)"
,
Apr 25 2017
I figured that was covered here (I missed the "sub-sub" page bit. https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/printing_page/printing_page.js?q=printing_page.js+package:%5Echromium$&dr&l=47 And I didn't see any other 'subpage-arrow' references. Looking more closely, it looks like we show the printer details from an action menu. What is the expected behavior there?
,
Apr 25 2017
My guess is that we would want to focus the "dots" icon that corresponds to the printer details that were exited. But perhaps focusing some other element regardless of which printer was shown would be sufficient. We already do the latter in the cookies details case, where we always focus the cookies search input (see screenshot).
,
Apr 25 2017
I filed a separate issue 715248 to track the cups printing changes.
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfd9716d05641238fc5e00e0f83ec8862928974a commit bfd9716d05641238fc5e00e0f83ec8862928974a Author: stevenjb <stevenjb@chromium.org> Date: Thu Apr 27 20:49:14 2017 MD Settings: Fix subpage navigation focus for bluetooth+internet This CL: * Fixes the subpage arrow for bluetooth and focus it correctly. * Provides focus logic for internet-page -> internet-subpage -> internet-detail-page. * Fixes keyboard navigation to details page from cr-network-list-item BUG= 714350 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2841873004 Cr-Commit-Position: refs/heads/master@{#467783} [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/chrome/browser/resources/settings/internet_page/internet_page.html [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/chrome/browser/resources/settings/internet_page/internet_page.js [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/bfd9716d05641238fc5e00e0f83ec8862928974a/ui/webui/resources/cr_elements/network/cr_network_list_item.html
,
Apr 27 2017
,
May 20 2017
9563.0.0, 60.0.3102.0 Focus works fine on the internet in main settings page. But when I click on '>' icon to open any internet details page and come back to internet subpage, there is no focus on the arrow '>' icon. Same is the case with Known networks page Attached video: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/714350/mdsettings_focus.webm?_ga=1.21840827.1204488054.1493153045
,
Jun 5 2017
,
Jun 27 2017
Punting on fixing returning from a network detail page, at least for now.
I can successfully set the selector for the item, however setting focusConfig_ does not successfully focus the item on navigation, probably because it is it is multiply nested and templated (selector is "/deep/ #networkList cr-network-list-item[guid="{guid}"] /deep/ .subpage-arrow")
Re-marking this uber bug as fixed and created issue 736963.
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by steve...@chromium.org
, Apr 24 2017Owner: steve...@chromium.org
Status: Assigned (was: Available)