Two methods in WifiDataProviderCommon [1] // Returns ownership. virtual WlanApiInterface* NewWlanApi() = 0; // Returns ownership. virtual WifiPollingPolicy* NewPollingPolicy() = 0; have move-only unique_ptr<> semantics. Change them accordingly. [1] https://cs.chromium.org/chromium/src/device/geolocation/wifi_data_provider_common.h?type=cs&q=WifiDataProviderCommon&sq=package:chromium&l=32
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b477ea757773359fb6d25a643815ded1c0660909 commit b477ea757773359fb6d25a643815ded1c0660909 Author: mcasas <mcasas@chromium.org> Date: Mon Apr 24 21:24:45 2017 Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla() Cleanup to renamed NewWlanApi to CreateWlanApi and NewPollingPolicy() to CreatePollingPolicy(), and made them return unique_ptr<> ISO a naked ptrs. Also in device/geolocation/wifi_data_provider_win.cc removed {} for one-line bodies and also had to change the signaure of two internal Create() methods (and make ctors public to be accessible by base::MakeUnique<>). BUG= 714348 Review-Url: https://codereview.chromium.org/2833273002 Cr-Commit-Position: refs/heads/master@{#466771} [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_common.cc [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_common.h [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_common_unittest.cc [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_linux.cc [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_linux.h [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_linux_unittest.cc [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_mac.h [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_mac.mm [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_win.cc [modify] https://crrev.com/b477ea757773359fb6d25a643815ded1c0660909/device/geolocation/wifi_data_provider_win.h
Comment 1 by mcasas@chromium.org
, Apr 24 2017