3 classes of separator types |
||||||||||||||||||||||||||||
Issue descriptionThe padding between a component and a vertical separator should be different depending on the component. The padding between the left-most icon and the separator should always be 12px.
,
Apr 24 2017
,
Apr 24 2017
,
Apr 25 2017
Update: settings-ripple is going to use cr-ripples. So the diameter is now 36 instead of 40. With that change, use 16 (instead of 12) for spacing between icon and vertical separator/card edge. Exception being switches and buttons.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/898ae07dedccc8e9a9a125c662ce1c28af55d41f commit 898ae07dedccc8e9a9a125c662ce1c28af55d41f Author: dschuyler <dschuyler@chromium.org> Date: Mon May 01 23:04:07 2017 [MD settings] css for row separator This CL adds CSS for .separator which is a grey separator line between controls on a row (e.g. settings-box). The intent is to replace .secondary-action (a TODO has been added to that effect). This initial CL changes the separator lines seen in the basic main page of MD settings. (a step to fix, but not complete fix). BUG= 714320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2847583002 Cr-Commit-Position: refs/heads/master@{#468471} [modify] https://crrev.com/898ae07dedccc8e9a9a125c662ce1c28af55d41f/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/898ae07dedccc8e9a9a125c662ce1c28af55d41f/chrome/browser/resources/settings/default_browser_page/default_browser_page.html [modify] https://crrev.com/898ae07dedccc8e9a9a125c662ce1c28af55d41f/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/898ae07dedccc8e9a9a125c662ce1c28af55d41f/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/898ae07dedccc8e9a9a125c662ce1c28af55d41f/chrome/test/data/webui/settings/appearance_page_test.js
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e51eab19200adc5c174f8a792cb917a9e2a4e13 commit 3e51eab19200adc5c174f8a792cb917a9e2a4e13 Author: dschuyler <dschuyler@chromium.org> Date: Tue May 02 01:35:07 2017 [MD settings] replace secondary-action with separator This CL replaces the use of the .secondary-action class with the .separator class. This simplifies the row separators allowing for more custom styling of the secondary actions. BUG= 714320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2849663002 Cr-Commit-Position: refs/heads/master@{#468528} [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/about_page/about_page.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/about_page/detailed_build_info.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/android_apps_page/android_apps_page.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/downloads_page/downloads_page.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/internet_page/network_siminfo.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/internet_page/network_summary_item.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/search_page/search_page.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/site_settings/site_data.html [modify] https://crrev.com/3e51eab19200adc5c174f8a792cb917a9e2a4e13/chrome/browser/resources/settings/site_settings/site_list.html
,
May 2 2017
These screen shots are of the fixed version. These have been reviewed by bettes@ to verify correctness.
,
May 3 2017
Talked with Dave online, and came to the conclusion of "don't fix what's not broken." The 12px padding between icon/component and edge of card is WAI and, judging from the screenshots above, align nicely with the rest of the UI.
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a68250c14a6e3a9053b9bd650db14943764ca95 commit 9a68250c14a6e3a9053b9bd650db14943764ca95 Author: dschuyler <dschuyler@chromium.org> Date: Mon May 15 21:34:34 2017 [MD settings] adjust control spacing This CL makes several small adjustments to control/item spacing as requested by bettes@. The following items were tweaked: toggle button width, controlled button to policy icon spacing, and ripple size on icon buttons. BUG= 714320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2873163002 Cr-Commit-Position: refs/heads/master@{#471908} [modify] https://crrev.com/9a68250c14a6e3a9053b9bd650db14943764ca95/chrome/browser/resources/settings/controls/controlled_button.html [modify] https://crrev.com/9a68250c14a6e3a9053b9bd650db14943764ca95/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/9a68250c14a6e3a9053b9bd650db14943764ca95/chrome/browser/resources/settings/settings_vars_css.html
,
May 15 2017
|
||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Apr 24 2017Labels: -Pri-3 OS-All Pri-2
Status: Available (was: Untriaged)