clarify uprev logging when skipping uprev |
|||||
Issue descriptionexample: https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/14364/steps/Uprev/logs/stdio full of lines like: 13:20:25: INFO: Determined that none of the rev_subdirs [] of ebuild autotest-cheets-playmusic was touched. Looks to me like it is saying that nothing from an empty list was touched. That's confusing. Can this logging be clearer?
,
Apr 25 2017
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/46784b14ef14cc699886ed058fa207c3ee8da2ae commit 46784b14ef14cc699886ed058fa207c3ee8da2ae Author: Prashant Malani <pmalani@google.com> Date: Fri Apr 28 09:58:16 2017 Clarify logging string in UpRev decision function The logging string that mentions the subdirs in which changes were detected was using a incorrect variable. This patch corrects that. It also adds some logging to for the _ShouldRevEBuild() function. BUG= chromium:714319 TEST="cros_mark_as_stable commit --all --boards=veyron_minnie" locally Change-Id: I61fd5267ce779fb3b4b2e1ce5370fb61e20e4847 Reviewed-on: https://chromium-review.googlesource.com/488137 Commit-Ready: Prashant Malani <pmalani@google.com> Tested-by: Prashant Malani <pmalani@google.com> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/46784b14ef14cc699886ed058fa207c3ee8da2ae/lib/portage_util.py
,
Apr 28 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pmalani@chromium.org
, Apr 25 2017