New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714294 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

When saving the config information - frequently the bucket name reverts to default

Project Member Reported by haddowk@chromium.org, Apr 21 2017

Issue description


Quite often when adding the configuration information in for moblab ( boto key, secret and bucket name ) when you press save the bucket name will revert back to the default images setting.

It is thought this is caused by not shutting down apache gracefully.

Fix upstart so that apache graceful shutdown is achieved.

 

Comment 1 by ntang@google.com, Apr 24 2017

this should be a P1 issue if it happens at partner sites.
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4484e6f88214d5e6330fdea7d2ddd264debf81dd

commit 4484e6f88214d5e6330fdea7d2ddd264debf81dd
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed May 03 03:24:22 2017

[moblab] Set enviroment variables so restart works correctly.

Certain conf files for moblab rely on previous conf files setting
enviroment variables, this causes issues when a single process with
a dependency is restarted.  Ensure that devserver and devserver
cleanup can be restarted correctly.

BUG= chromium:714294 
TEST=local tests on dev moblab.

Change-Id: Id23d8b46aec326710ba994ab7e57887d9708622f
Reviewed-on: https://chromium-review.googlesource.com/493869
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/4484e6f88214d5e6330fdea7d2ddd264debf81dd/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-devserver-cleanup-init.conf
[rename] https://crrev.com/4484e6f88214d5e6330fdea7d2ddd264debf81dd/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r54.ebuild
[modify] https://crrev.com/4484e6f88214d5e6330fdea7d2ddd264debf81dd/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 3 by bugdroid1@chromium.org, May 5 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/8db6c761221003590f6fb4caf7c4b34beb4f9817

commit 8db6c761221003590f6fb4caf7c4b34beb4f9817
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 05 22:39:40 2017

[moblab] Set enviroment variables so restart works correctly.

Certain conf files for moblab rely on previous conf files setting
enviroment variables, this causes issues when a single process with
a dependency is restarted.  Ensure that devserver and devserver
cleanup can be restarted correctly.

BUG= chromium:714294 
TEST=local tests on dev moblab.

Change-Id: Id23d8b46aec326710ba994ab7e57887d9708622f
Reviewed-on: https://chromium-review.googlesource.com/494068
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/8db6c761221003590f6fb4caf7c4b34beb4f9817/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-devserver-cleanup-init.conf
[rename] https://crrev.com/8db6c761221003590f6fb4caf7c4b34beb4f9817/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r54.ebuild
[modify] https://crrev.com/8db6c761221003590f6fb4caf7c4b34beb4f9817/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 4 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/8db6c761221003590f6fb4caf7c4b34beb4f9817

commit 8db6c761221003590f6fb4caf7c4b34beb4f9817
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 05 22:39:40 2017

[moblab] Set enviroment variables so restart works correctly.

Certain conf files for moblab rely on previous conf files setting
enviroment variables, this causes issues when a single process with
a dependency is restarted.  Ensure that devserver and devserver
cleanup can be restarted correctly.

BUG= chromium:714294 
TEST=local tests on dev moblab.

Change-Id: Id23d8b46aec326710ba994ab7e57887d9708622f
Reviewed-on: https://chromium-review.googlesource.com/494068
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/8db6c761221003590f6fb4caf7c4b34beb4f9817/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-devserver-cleanup-init.conf
[rename] https://crrev.com/8db6c761221003590f6fb4caf7c4b34beb4f9817/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r54.ebuild
[modify] https://crrev.com/8db6c761221003590f6fb4caf7c4b34beb4f9817/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-scheduler-init.conf

Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/350d7890fe5081f3e99684366fd80386cae271a8

commit 350d7890fe5081f3e99684366fd80386cae271a8
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed May 10 18:58:25 2017

[moblab] Call new upstart command that correctly restarts apache.

restart moblab-apache-init does not cleanly or correctly restart
apache, call a new upstart config that calls the correct command
to restart apache.

Replace the use of the boto library with a gsutil command.

Use the same path to the gsutil command that the devserver uses.

BUG= chromium:714294 
TEST=locally on moblab, unittests

Change-Id: I0befe734d2c6130dadcfdaa5984aec23bba07807
Reviewed-on: https://chromium-review.googlesource.com/497169
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/350d7890fe5081f3e99684366fd80386cae271a8/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/350d7890fe5081f3e99684366fd80386cae271a8/frontend/afe/moblab_rpc_interface.py

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1dbc31a2cd1c77097e1d8c85af16634a899b3e87

commit 1dbc31a2cd1c77097e1d8c85af16634a899b3e87
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed May 10 21:59:42 2017

[moblab] Call new upstart command that correctly restarts apache.

restart moblab-apache-init does not cleanly or correctly restart
apache, call a new upstart config that calls the correct command
to restart apache.

Replace the use of the boto library with a gsutil command.

Use the same path to the gsutil command that the devserver uses.

BUG= chromium:714294 
TEST=locally on moblab, unittests

Change-Id: I0befe734d2c6130dadcfdaa5984aec23bba07807
Reviewed-on: https://chromium-review.googlesource.com/497169
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit 350d7890fe5081f3e99684366fd80386cae271a8)
Reviewed-on: https://chromium-review.googlesource.com/502188
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/1dbc31a2cd1c77097e1d8c85af16634a899b3e87/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/1dbc31a2cd1c77097e1d8c85af16634a899b3e87/frontend/afe/moblab_rpc_interface.py

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment