New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714282 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

mario eol: no notifications anywhere

Project Member Reported by vapier@chromium.org, Apr 21 2017

Issue description

i installed current mario stable channel (56.0.2924.121 / 9000.97.0) from a recovery image and i'm not seeing any EOL notifications anywhere.  obtained via:
  cros flash usb:// xbuddy://remote/x86-mario/latest-stable/recovery

- went through the OOBE process, and the "checking for security updates" showed nothing
- logged in and didn't see any notifications
- went to chrome://settings/help, clicked check for updates, and it says "Your Chromebook is up to date"
 

Comment 1 by gkihumba@google.com, Apr 21 2017

Cc: dhadd...@chromium.org
Cc: sdantul...@chromium.org abod...@chromium.org rookrishna@chromium.org moisesos...@chromium.org
Can we see if this repro's? 

I checked this originally in M56 but haven't looked at it since.
It could be the omaha config for mario no longer has the _eol status entry 
I don't see the EOL flag being set for mario. So that's why. I think there should be a manual rule for this, gkihumba@ can say better.
Tested on M57(9083.0.0) with recovery install and no eol notification at chrome://settings/help.
What is the value if you run the following in the terminal?
$update_engine_client --eol_status

I think only eol status=eol will trigger eol notification.
$update_engine_client --eol_status
EOL_STATUS=supported

Comment 7 by gkihumba@google.com, Apr 24 2017

I suspect the .mos file eol edits were overwritten...perhaps by manual rules added later. Will do another manual rule and discuss with Moises how we can keep track of versions for rollbacks, if possible.

Comment 8 by ihf@chromium.org, Apr 24 2017

Cc: ihf@chromium.org
Cc: xiaoyinh@chromium.org
Owner: gkihumba@chromium.org
Status: Assigned (was: Unconfirmed)
The lack of updates has been fixed with a repush (b/36216012). I'm handing this over to Grace so that she can add the corresponding manual rules for the notification to appear.
is there a test somewhere we can add to make sure this doesn't revert/break again ?  it's not like the M56/mario client code is going to ever change, and it's going to be more important as we EOL more devices (with alex/zgb up next).
Automated support is coming to GoldenEye. It's been done for canary channel already, but others are more troublesome as there's no easy indication on when to set the flag (canary is easy because GoldenEye itself does the pushes automatically).

GoldenEye has proper tests so once it's automated we can rely on it with more confidence. Support will be added this Q2.
Manual rules have been added

Comment 14 by ihf@chromium.org, May 1 2017

This is a bit outside of the scope of this issue, but maybe not. I really wish we would have EOLed alex and zgb in the same release. Similar with other SOC generations. Creating per-board EOL dates (effectively EOLing leaders before followers) makes things a bit more complicated than it should be. IMHO etc.
i'm not sure mario/alex/zgb were really leaders/followers.  more that they were just the only 32-bit x86 boards we still had.

that said, they had release dates months apart, so if we wanted to clamp at 5 years, we wouldn't be able to anyways.  not that i'm against extending EOL dates when possible :).

Comment 16 by ihf@chromium.org, May 1 2017

All three are pinetrail SOC, mario was leader, alex/zgb followers by today's terminology. But they basically share all bugs/fixes. Same for sandybridge (lumpy/stumpy) and newer Intel SOC generations.
Configs are live.
https://omahaconsole.corp.google.com/diff?pid=189&fromcfgid=323&tocfgid=324&pretty

Mike/ David please test with your Marios to see if eol notification pops up now.
it didn't show the first check, but it showed on refresh.  probably not an edge case that most people will run into, and not like we can fix it now for mario :).

i'm seeing it at the chrome://settings about page, and i'm seeing it when i login as my user.  i'm not seeing it at OOBE or guest mode, but i'm guessing those are unrelated, so i'll file new bugs.
Status: Fixed (was: Assigned)
Ok. Marking this as fixed.
Labels: VerifyIn-61

Comment 21 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment