New issue
Advanced search Search tips

Issue 714281 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fix a possible race with google variation ID registration

Project Member Reported by rajendrant@chromium.org, Apr 21 2017

Issue description

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96efb190e51a943b44485a8b3c53338498814c43

commit 96efb190e51a943b44485a8b3c53338498814c43
Author: rajendrant <rajendrant@chromium.org>
Date: Fri Apr 21 22:17:53 2017

Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG= 714281 

Review-Url: https://codereview.chromium.org/2834463005
Cr-Commit-Position: refs/heads/master@{#466464}

[modify] https://crrev.com/96efb190e51a943b44485a8b3c53338498814c43/chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc
[modify] https://crrev.com/96efb190e51a943b44485a8b3c53338498814c43/chrome/browser/android/data_usage/external_data_use_observer.cc
[modify] https://crrev.com/96efb190e51a943b44485a8b3c53338498814c43/chrome/browser/android/data_usage/external_data_use_observer.h
[modify] https://crrev.com/96efb190e51a943b44485a8b3c53338498814c43/chrome/browser/android/data_usage/external_data_use_observer_bridge.cc
[modify] https://crrev.com/96efb190e51a943b44485a8b3c53338498814c43/chrome/browser/android/data_usage/external_data_use_observer_bridge.h

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 28 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f13f69fe4a756b04306ee416f676812f7394826b

commit f13f69fe4a756b04306ee416f676812f7394826b
Author: rajendrant <rajendrant@chromium.org>
Date: Fri Apr 28 05:53:27 2017

Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG= 714281 

Review-Url: https://codereview.chromium.org/2834463005
Cr-Commit-Position: refs/heads/master@{#466464}
(cherry picked from commit 96efb190e51a943b44485a8b3c53338498814c43)

Review-Url: https://codereview.chromium.org/2852643002 .
Cr-Commit-Position: refs/branch-heads/3071@{#284}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f13f69fe4a756b04306ee416f676812f7394826b/chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc
[modify] https://crrev.com/f13f69fe4a756b04306ee416f676812f7394826b/chrome/browser/android/data_usage/external_data_use_observer.cc
[modify] https://crrev.com/f13f69fe4a756b04306ee416f676812f7394826b/chrome/browser/android/data_usage/external_data_use_observer.h
[modify] https://crrev.com/f13f69fe4a756b04306ee416f676812f7394826b/chrome/browser/android/data_usage/external_data_use_observer_bridge.cc
[modify] https://crrev.com/f13f69fe4a756b04306ee416f676812f7394826b/chrome/browser/android/data_usage/external_data_use_observer_bridge.h

Status: Fixed (was: Started)

Sign in to add a comment