New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714265 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Button highlight / ripple is sometimes visible during touch-swipe of the Ash shelf

Project Member Reported by tdander...@chromium.org, Apr 21 2017

Issue description

Seen on: 59.0.3070.0 canary, but has likely been around for a while

Steps to reproduce:
1. Close all windows.
2. Align shelf to the bottom (though bug does repro for other alignments).
3. Position finger directly underneath the system tray, then swipe upwards to invoke the shelf 'stretch' animation.

What happens:
A highlight (ripple) appears within the system tray bounds and remains visible throughout the entire shelf-stretch animation.

What should happen instead:
The highlight should disappear as soon as the shelf begins to stretch.


Notes:

* Also reproduces for other buttons in the status tray area (status tray, notification center, VK button, opt-in IME button, etc), the overflow button in the shelf, and the launcher. (In the case of the launcher, the highlight actually persists after the stretching animation has ended.)

* If you follow the repro steps with at least one open window (i.e., omit step (1)), then the bug reproduces when swiping to reveal a hidden shelf, but does NOT repro when swiping to hide a visible shelf.

* It is expected that a highlight will begin to appear at the point where the finger comes in contact with the button but before the shelf-stretch animation begins. But once the animation begins the highlight should disappear; this expected behavior can be seen when swiping to hide a visible shelf with at least one window open.
 

Comment 1 by zork@chromium.org, Apr 21 2017

Owner: sammiequon@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6e6113a0f57941108e5267f699bd7dd740828b

commit 8c6e6113a0f57941108e5267f699bd7dd740828b
Author: sammiequon <sammiequon@chromium.org>
Date: Tue May 02 00:13:02 2017

views: Button ripple/highlight is visible during shelf swipe.

More details in the bug.

TEST=manual
BUG= 714265 

Review-Url: https://codereview.chromium.org/2840773003
Cr-Commit-Position: refs/heads/master@{#468501}

[modify] https://crrev.com/8c6e6113a0f57941108e5267f699bd7dd740828b/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/8c6e6113a0f57941108e5267f699bd7dd740828b/ui/views/animation/ink_drop_host_view.cc

Status: Fixed (was: Assigned)
Labels: Proj-MaterialDesign-CrOS M-60
Status: Verified (was: Fixed)
9563.0.0, 60.0.3102.0

Sign in to add a comment