New issue
Advanced search Search tips

Issue 714244 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Task



Sign in to add a comment

Disable ButterBar in CRD

Project Member Reported by sergeyu@chromium.org, Apr 21 2017

Issue description

The butter bar in CRD app currently links to a survey. It needs to be disabled for now until we have new content to put there.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96c22ff94cdd4c7d46c1f50d26879ac1107fe0c0

commit 96c22ff94cdd4c7d46c1f50d26879ac1107fe0c0
Author: sergeyu <sergeyu@chromium.org>
Date: Fri Apr 21 21:35:16 2017

Disable ButterBar in chromoting webapp

BUG= 714244 

Review-Url: https://codereview.chromium.org/2830013006
Cr-Commit-Position: refs/heads/master@{#466452}

[modify] https://crrev.com/96c22ff94cdd4c7d46c1f50d26879ac1107fe0c0/remoting/webapp/crd/js/crd_main.js

Labels: Merge-Request-59
I'd like to merge this change to M-59: https://codereview.chromium.org/2830013006
This change is in Chrome Remote Desktop app and doesn't affect chrome.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 22 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Apr 23 2017

Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
Components: Services>Chromoting
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 24 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51dbc5c4ebf1d3ca44a90899c44b39c27333047d

commit 51dbc5c4ebf1d3ca44a90899c44b39c27333047d
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Apr 24 17:07:47 2017

Disable ButterBar in chromoting webapp

BUG= 714244 

Review-Url: https://codereview.chromium.org/2830013006
Cr-Commit-Position: refs/heads/master@{#466452}
(cherry picked from commit 96c22ff94cdd4c7d46c1f50d26879ac1107fe0c0)

Review-Url: https://codereview.chromium.org/2838623002 .
Cr-Commit-Position: refs/branch-heads/3071@{#167}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/51dbc5c4ebf1d3ca44a90899c44b39c27333047d/remoting/webapp/crd/js/crd_main.js

Status: Fixed (was: Started)
Verified. There is no butter bar in app version 59.0.3071.47
Status: Verified (was: Fixed)

Sign in to add a comment