WebGL 2.0: Support RGB10_A2 textures in texImageSource variants of tex(Sub)Image(2D|3D) |
|||
Issue descriptionImplement support for Internal format: GL_RGB10_A2 format: GL_RGBA type: GL_UNSIGNED_INT_2_10_10_10_REV to texImageSource variants of tex(Sub)Image(2D|3D). WebGL 2.0 specification change is defined in: https://github.com/KhronosGroup/WebGL/issues/2274 and implemented in PS: https://github.com/KhronosGroup/WebGL/pull/2375
,
Apr 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a7adc3543e9b9b0bf44563830a3502ceba76650 commit 2a7adc3543e9b9b0bf44563830a3502ceba76650 Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com> Date: Sun Apr 30 21:15:54 2017 WebGL: tex(Sub)Image(2D|3D) texImageSource support for RGB10_A2 textures. See: https://github.com/KhronosGroup/WebGL/issues/2274 BUG= 714240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2821363003 Cr-Commit-Position: refs/heads/master@{#468257} [modify] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc [modify] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/2a7adc3543e9b9b0bf44563830a3502ceba76650/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
,
May 15 2017
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bff46cd3bbe895665721d642819264f1aad6520 commit 8bff46cd3bbe895665721d642819264f1aad6520 Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com> Date: Mon May 15 16:29:51 2017 Roll WebGL 6517159..87aaf44 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6517159..87aaf44 BUG= 714240 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2882993002 Cr-Commit-Position: refs/heads/master@{#471785} [modify] https://crrev.com/8bff46cd3bbe895665721d642819264f1aad6520/DEPS [modify] https://crrev.com/8bff46cd3bbe895665721d642819264f1aad6520/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
May 17 2017
,
May 18 2017
Excellent work Aleks. Thank you for pushing this tricky spec and implementation change through.
,
May 18 2017
No, thank you; for motivating me [1] to contribute to WebGL specs and tests. I hadn't done not planned it before. As a follow up, I'll start analyzing if we can improve performance for HDR-9/10 video by using RGB10_A2 or R32F (as a replacement of current R16F). [1] https://github.com/KhronosGroup/WebGL/issues/2274#issuecomment-279897651 |
|||
►
Sign in to add a comment |
|||
Comment 1 by aleksand...@intel.com
, Apr 22 2017