The onboarding flow needs to be consolidated so that we can figure out what a user has been shown or needs to be shown. go/clank-onboarding-flow
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1046c549109b2dfdcf18b6f2336460f14daf88d3 commit 1046c549109b2dfdcf18b6f2336460f14daf88d3 Author: dfalcantara <dfalcantara@chromium.org> Date: Wed Apr 26 22:41:27 2017 ❄ Introduce header and footer logic to search engine promos * Add the ability to PromoDialog to be able to keep a header and footer fixed while the contents are scrollable. Scrollable content is indicated by a never disappearing scrollbar indicator. * Adds the ability to add a InfoBarControlLayout to the PromoDialogLayout. This is used to standardize the buttons that are displayed across dialogs. * Add the ability to add tags to the InfoBarControlLayout radio buttons. These are needed because IDs aren't set for the radio buttons, and because it is safer to keep track of the search engine keywords with the RadioButtons that represent them. Things to do: - InfoBarControlLayout needs to move to the widget/ directory and be generalized so that they're not so infobar specific. - Tests are in a separate CL. Example screenshots: https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM BUG= 714223 ,712836,712833 Review-Url: https://codereview.chromium.org/2839253002 Cr-Commit-Position: refs/heads/master@{#467488} [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/res/layout/promo_dialog_layout.xml [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialog.java [modify] https://crrev.com/1046c549109b2dfdcf18b6f2336460f14daf88d3/chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42776f8a5b7e07ce63442004737150495eed0db0 commit 42776f8a5b7e07ce63442004737150495eed0db0 Author: dfalcantara <dfalcantara@chromium.org> Date: Thu Apr 27 20:28:16 2017 🔍 Introduce default search engine dialog Add a dialog that can be triggered via LocaleManager that allows a user to choose their default search engine from a randomized list. DefaultSearchEnginePromoDialog: * Add a basic dialog that forces a user to select a default search engine. This dialog only shows up for the "existing user" case and (currently) randomizes the search engines available as defined in the TemplateUrlService. * Add the ability to show the DefaultSearchEnginePromoDialog from the LocaleManager. It currently never fires because the logic hasn't landed, but it is triggered from ChromeTabbedActivity and SearchActivity. Things to do: - Still trying to figure out how to test this. Screenshots: https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM BUG= 714223 ,712836,712833 Review-Url: https://codereview.chromium.org/2838833002 Cr-Commit-Position: refs/heads/master@{#467766} [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java [add] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchBoxDataProvider.java [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/42776f8a5b7e07ce63442004737150495eed0db0/chrome/android/java_sources.gni
Main pathways have been merged and mainly cosmetic bugs were found. Blockers are being tracked in separate bugs.
Comment 1 by bsazonov@chromium.org
, Apr 24 2017