New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

[Sync] Include ModelTypeController state in sync-internals

Project Member Reported by s...@chromium.org, Apr 21 2017

Issue description

When trying to debug why something isn't working, I've often wished I had an easy way to access the ModelTypeController's state field. It seems like adding this to the Type Info grid on the About page of sync-internals would be a reasonably good fit.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cfadad67cd27254cce5ae62891aab6f5fc1d643

commit 0cfadad67cd27254cce5ae62891aab6f5fc1d643
Author: skym <skym@chromium.org>
Date: Fri Apr 21 23:13:11 2017

[Sync] Update Type Info section of sync-internals.

* Added DataTypeController's State to sync-internals. This should make
debugging certain issues significantly easier.
* Stopped double requesting directory status counters.
* ModelSafeGroup's ToString is no longer SHOUTY_CAPS, but Captialized
Words to be in line with ModelType, and to allow sync-internals to put
line breaks between them.
* ModelSafeGroup's ToString no longer has a default clause, to force
new values to have handling added at compile time.
* Split up ModelSafeGroup and a status/health message into two separate
column on sync-internals.
* Updated javascript updating logic to apply status counters to
correctly write zeros.

BUG= 714198 

Review-Url: https://codereview.chromium.org/2834453006
Cr-Commit-Position: refs/heads/master@{#466486}

[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/chrome/browser/ui/webui/sync_internals_browsertest.js
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/driver/data_type_controller.cc
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/driver/data_type_controller.h
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/driver/resources/about.html
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/driver/resources/about.js
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/engine/model_safe_worker.cc
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/engine/model_safe_worker_unittest.cc
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/0cfadad67cd27254cce5ae62891aab6f5fc1d643/components/sync/syncable/model_type.cc

Comment 2 by s...@chromium.org, Apr 24 2017

Status: Fixed (was: Started)

Sign in to add a comment