New issue
Advanced search Search tips

Issue 714180 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 681694



Sign in to add a comment

Size diff does not have 100% coverage for .text

Project Member Reported by agrieve@chromium.org, Apr 21 2017 
This can lead to confusion. E.g. today I was looking at:
https://codereview.chromium.org/2831503002

Where the size diff shows 40k change, but symbols account for only 86 bytes:

Section Sizes (Total=-40,004 bytes):
    .bss: 32 bytes (not included in totals)
    .data: 0 bytes (-0.0%)
    .data.rel.ro: 0 bytes (-0.0%)
    .data.rel.ro.local: 16 bytes (-0.0%)
    .rodata: 0 bytes (-0.0%)
    .text: -40,020 bytes (100.0%)

15 symbols added (+), 86 changed (~), 15 removed (-), 316622 unchanged (not shown)
0 object files added, 0 removed

Showing 116 symbols with total size: -86 bytes
.text=-102 bytes .rodata=0 bytes    other=16 bytes   total=-86 bytes
Number of object files: 102
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2de1cc0bc6bfc831331f083e8434f15c11ad9021

commit 2de1cc0bc6bfc831331f083e8434f15c11ad9021
Author: agrieve <agrieve@chromium.org>
Date: Wed May 03 17:23:06 2017

Create a star symbol for gaps at the start & end of sections

This eliminates the chance of a diff coming up where the symbols do not
sum up to the entire section delta

Other misc changes here:
 * Improves the size summary messaging.
 * Kills nm subprocess upon exit (rather than letting process finish)
 * Allows linker maps to not have a Common Symbols section

BUG= 714180 

Review-Url: https://codereview.chromium.org/2858793002
Cr-Commit-Position: refs/heads/master@{#469017}

[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/cluster_symbols.py
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/describe.py
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/linker_map_parser.py
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/models.py
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/nm.py
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/Archive.golden
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/Archive_Elf.golden
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/Archive_OutputDirectory.golden
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/Console.golden
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/Diff_Basic.golden
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/FullDescription.golden
[modify] https://crrev.com/2de1cc0bc6bfc831331f083e8434f15c11ad9021/tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden

Comment 2 by agrieve@chromium.org, May 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment