New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714169 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocking:
issue 702391



Sign in to add a comment

Update style of native dialogs in OOBE

Project Member Reported by zalcorn@chromium.org, Apr 21 2017

Issue description

"Learn more" and "System security setting" dialogs should be updated to match new-OOBE spec: https://folio.googleplex.com/cros-oobe-main-flow# (screens 03D, 05C, all learn more links).
 

Comment 1 by wzang@chromium.org, Apr 26 2017

Cc: r...@chromium.org
Owner: wzang@chromium.org

Comment 2 Deleted

Comment 3 by wzang@chromium.org, Apr 27 2017

Cc: zalcorn@chromium.org
zalcorn@,  do you mean for 05C we should consolidate the paragraph 'Visit the..' into a blue 'Learn more' link? What should be changed about 03D? 
Sorry for lack of clarity. The screens shown in  03D, 05C, and the learn more dialogs are all currently using native dialogs that do not match the spec. We should update the look of all dialogs to be in-spec.
The attached is the spec for the native dialogs. Please let me know if you have any questions.
SPEC-settings_dialogs.png
441 KB View Download

Comment 6 by morsed@google.com, May 3 2017

In the process of making available this piece of content via the HelpApp:

About the Trusted Platform Module (TPM)
https://redwood.corp.google.com/4441112 

Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/4f18e8f8a47d4754fcf4340245084d7e0dc74391

commit 4f18e8f8a47d4754fcf4340245084d7e0dc74391
Author: David Morse <morsed@google.com>
Date: Thu May 11 03:58:06 2017

Comment 8 by morsed@google.com, May 11 2017

Two new HelpApp articles for the OOBE landed in 9540.0.0/60.0.3092.0

http://redwood/4441112
http://redwood/6204310
 Issue 706041  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b214e88215d27854998ed5a3a4596a212afbe12

commit 0b214e88215d27854998ed5a3a4596a212afbe12
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Feb 28 05:37:46 2018

cros: Implement md-style EULA security settings screen

Given the simplicity of this page, it's inlined with the EULA screen.

Based on the mock goo.gl/YegUvx, the screen is no longer a small
overlay as the non-md style, so did not combine the md/non-md together
in the same file like other screens.

Bug: 714169
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifffd4c2d5b47d4b22e6283d6985df2842c83adf6
Reviewed-on: https://chromium-review.googlesource.com/936477
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539721}
[modify] https://crrev.com/0b214e88215d27854998ed5a3a4596a212afbe12/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/0b214e88215d27854998ed5a3a4596a212afbe12/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/0b214e88215d27854998ed5a3a4596a212afbe12/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/0b214e88215d27854998ed5a3a4596a212afbe12/chrome/browser/resources/chromeos/login/oobe_eula.js
[modify] https://crrev.com/0b214e88215d27854998ed5a3a4596a212afbe12/chrome/browser/resources/chromeos/login/oobe_screen_eula.js

Cc: wzang@chromium.org
Labels: -Pri-2 -Hotlist-auth-polish Hotlist-OOBE-polish Pri-3
Owner: ----
Status: Available (was: Assigned)
Looks like the "Learn More" dialogs still need updating (as of 72.0.3593.0), so we can keep this open. 
I'll mark available so someone can pick it up.

Sign in to add a comment