New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714167 link

Starred by 2 users
Status: Verified
Owner:
emaxx@chromium.org
Closed: May 2017
Cc:
█ bartfab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: ----



Sign in to add a comment

browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by fhorschig@chromium.org, Apr 21 2017 
Assigning to emaxx@ (who recently submitted something fighting flakiness) as they might provide more insight here.

browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/25167
and
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/25173

Both times, SAMLPolicyTest.*TransferCookiesUnaffiliated were involved and timed out at least once.

https://chromium-swarm.appspot.com/task?id=35a97313a80e9510&refresh=10&show_raw=1
and
https://chromium-swarm.appspot.com/task?id=35a9d6af3c810210&refresh=10&show_raw=1

The first failure actually has a stacktrace, but this might be misleading, given that the timeout seems to be the bigger problem:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Tests__dbg__1_%2F25167%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FSAMLPolicyTest.PRE_TransferCookiesUnaffiliated%2F0

Comment 1 by emaxx@chromium.org, Apr 21 2017 

Yes, I re-enabled this test everywhere except MSan and ASan in  bug 683161  (commit 1e04e1de4401bf105333158e4cb314fa834c5fa8). The hypothesis there was that the test was just running too slow in the sanitized builds.

So it may be that the problem is there for debug builds too.


fhorschig@: Do you maybe know how to interpret the flakiness diagram ([1])? It shows "TIMEOUT PASS" for most runs of the test under dbg - does this mean that the test finishes successfully after the timeout, or it says that the test was run twice and only the second execution succeeded?

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TransferCookiesUnaffiliated

Comment 2 by emaxx@chromium.org, Apr 21 2017

Status: Assigned (was: Available)

Comment 3 by tdander...@chromium.org, Apr 22 2017 

The two builders mentioned in #0 are now consistently green; can this issue be closed out?

Comment 4 by sky@chromium.org, Apr 28 2017

Labels: -Sheriff-Chromium
ping emaxx
I don't see these tests failing recently, so I'm removing Sheriff-Chromium.

Comment 5 by emaxx@chromium.org, Apr 28 2017

Status: Started (was: Assigned)
The flakiness dashboard still displays these tests with a lot of TIMEOUT results on the dbg builder.

After measuring the execution times locally, I see about x5 slowdown in the Debug mode, which quite agrees with the data displayed at the dashboard: 4-5 s in Release mode, 40-50 s in Debug mode (marked as TIMEOUT).
Therefore assuming it's just a slowness of the test in general, and, as there's nothing obvious that can be improved in it, will have to file a CL with disabling these tests in Debug builds.
Project Member

Comment 6 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d13854ee9bf02222c3a67552f9fa1875ed6e969e

commit d13854ee9bf02222c3a67552f9fa1875ed6e969e
Author: emaxx <emaxx@chromium.org>
Date: Mon May 01 22:19:27 2017

Disable TransferCookiesUnaffiliated test under Debug

The SAMLPolicyTest.TransferCookiesUnaffiliated test and its PRE-test
were timing out in Debug builds.

There is nothing obvious that can be improved in the test. Also the
timeout times agree to some degree with the slowdown of the Debug mode
measured locally.

Therefore disabling this test in Debug builds.

BUG= 683161 , 714167 

Review-Url: https://codereview.chromium.org/2845393002
Cr-Commit-Position: refs/heads/master@{#468452}

[modify] https://crrev.com/d13854ee9bf02222c3a67552f9fa1875ed6e969e/chrome/browser/chromeos/login/saml/saml_browsertest.cc

Comment 7 by emaxx@chromium.org, May 11 2017

Status: Fixed (was: Started)

Comment 8 by kathrelk...@chromium.org, Jul 6 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment