Very flaky http/tests/inspector/network/waterfall-images.html |
||||
Issue descriptionSaw these two tests failing on a few WebKit bots quite a few times: http/tests/inspector/network/waterfall-images.html virtual/mojo-loading/http/tests/inspector/network/waterfall-images.html Example build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4153 Checking the Flakiness Dashboard and found that the test usually performs in a highly flaky way -- failing three times before finally passing. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=waterfall-images.html For example, these two tests failed three times before passing (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4152). Assigning to owner of the test. Please take a look at the test to see if you could improve it to make it non-flaky.
,
Apr 26 2017
This test is failing on corner pixels being slightly different colours. I think this test is overly susceptible to floating point rendering differences.
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7c815081037864e1725f873a89bab9088270a59 commit d7c815081037864e1725f873a89bab9088270a59 Author: sashab <sashab@chromium.org> Date: Wed Apr 26 06:09:32 2017 Mark virtual/mojo-loading/http/tests/inspector/network/waterfall-images.html as flaky BUG= 714166 Review-Url: https://codereview.chromium.org/2842763004 Cr-Commit-Position: refs/heads/master@{#467251} [modify] https://crrev.com/d7c815081037864e1725f873a89bab9088270a59/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 27 2017
I am not sure why, but this test still fails occasionally, e.g.: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25974 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25970 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/25958
,
Apr 27 2017
I have a good idea on why, but I'm trying to hold off for a few more weeks until we launch a new feature since the new feature works near this area.
,
Apr 28 2017
allada: can you please mark as fails so that it doesn't unnecessarily impact the main waterfall and others trying to submit patches? Removing Sheriff-Chromium as this has an owner and is being worked on.
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/920c268621477bdfa16464d0b8ef915703eacb00 commit 920c268621477bdfa16464d0b8ef915703eacb00 Author: allada <allada@chromium.org> Date: Mon May 01 21:48:25 2017 Mark waterfall-images.html as failure Per request here: http://crbug.com/714166 R=dgozman BUG= 714166 , 715405 Review-Url: https://codereview.chromium.org/2850923002 Cr-Commit-Position: refs/heads/master@{#468431} [modify] https://crrev.com/920c268621477bdfa16464d0b8ef915703eacb00/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 21 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31094ec5176869163611e4c81ade12e3e2985281 commit 31094ec5176869163611e4c81ade12e3e2985281 Author: Nathan Bruer <allada@chromium.org> Date: Wed Nov 15 02:53:00 2017 [Devtools] Fix waterfall test Some major refactoring of network panel should have resolved this flakey test. BUG=626703, 714166 Change-Id: I75133ec2de056f883febdf8639d24499eb802fa4 Reviewed-on: https://chromium-review.googlesource.com/583559 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516572} [modify] https://crrev.com/31094ec5176869163611e4c81ade12e3e2985281/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/31094ec5176869163611e4c81ade12e3e2985281/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-images.html
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0703517b9ec938354cbe34ed21462ad6b217c6cd commit 0703517b9ec938354cbe34ed21462ad6b217c6cd Author: Blaise Bruer <allada@chromium.org> Date: Wed Nov 15 07:39:07 2017 Revert "[Devtools] Fix waterfall test" This reverts commit 31094ec5176869163611e4c81ade12e3e2985281. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Devtools] Fix waterfall test > > Some major refactoring of network panel should have resolved this flakey > test. > > BUG=626703, 714166 > > Change-Id: I75133ec2de056f883febdf8639d24499eb802fa4 > Reviewed-on: https://chromium-review.googlesource.com/583559 > Commit-Queue: Blaise Bruer <allada@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516572} TBR=dgozman@chromium.org,caseq@chromium.org,allada@chromium.org Change-Id: I7692e2dd6074b1d98cee255e1c2887216af8e8f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 626703, 714166 Reviewed-on: https://chromium-review.googlesource.com/771071 Reviewed-by: Blaise Bruer <allada@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#516628} [modify] https://crrev.com/0703517b9ec938354cbe34ed21462ad6b217c6cd/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/0703517b9ec938354cbe34ed21462ad6b217c6cd/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-images.html
,
Dec 1 2017
Tests have been reverted. |
||||
►
Sign in to add a comment |
||||
Comment 1 by xlai@chromium.org
, Apr 21 2017