New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714155 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 714874
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

v8.top_25_smooth failing on 5 builders

Project Member Reported by simonhatch@chromium.org, Apr 21 2017

Issue description

Here's snippet from log:

Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 88, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 302, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/tools/perf/measurements/v8_gc_times.py", line 40, in ValidateAndMeasurePage
    self._AddV8MetricsToResults(renderer_process, results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/tools/perf/measurements/v8_gc_times.py", line 55, in _AddV8MetricsToResults
    self._AddCpuTimeStatsToResults(thread, results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/tools/perf/measurements/v8_gc_times.py", line 195, in _AddCpuTimeStatsToResults
    cpu_time = sum(s.thread_duration for s in thread.toplevel_slices)
TypeError: unsupported operand type(s) for +: 'float' and 'NoneType'
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 21 2017


=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : v8.top_25_smooth
  Metric       : v8_gc_total/v8_gc_total


To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.top_25_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981692102707726448

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5255305010610176


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Apr 21 2017


=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : v8.top_25_smooth
  Metric       : v8_gc_total/v8_gc_total


To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.top_25_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981677821159377088

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5255305010610176


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Apr 27 2017

Mergedinto: 714874
Status: Duplicate (was: Available)

=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : nhiroki
  Commit : d56a35fb25dc388a0506174b9e3fda67337313ce
  Date   : Thu Apr 20 01:05:33 2017
  Subject: Worker: Introduce per-global-scope task scheduler

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : v8.top_25_smooth
  Metric       : v8_gc_total/v8_gc_total

Revision             Exit Code      N
chromium@465783      0 +- N/A       20      good
chromium@465832      0 +- N/A       20      good
chromium@465838      0 +- N/A       20      good
chromium@465840      0 +- N/A       20      good
chromium@465841      1 +- N/A       20      bad       <--
chromium@465844      1 +- N/A       20      bad
chromium@465856      1 +- N/A       20      bad
chromium@465880      1 +- N/A       20      bad
chromium@465976      1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.top_25_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981214611540961264

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6450647123099648


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: nhiroki@chromium.org
Status: Assigned (was: Duplicate)
nhiroki: looks like your CL caused a crash in this performance test. Can you take a look?

I'll run another bisect to double check.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Apr 28 2017

Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : nhiroki
  Commit : d56a35fb25dc388a0506174b9e3fda67337313ce
  Date   : Thu Apr 20 01:05:33 2017
  Subject: Worker: Introduce per-global-scope task scheduler

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : v8.top_25_smooth
  Metric       : v8_gc_total/v8_gc_total

Revision             Exit Code      N
chromium@465783      0 +- N/A       20      good
chromium@465832      0 +- N/A       20      good
chromium@465838      0 +- N/A       20      good
chromium@465840      0 +- N/A       20      good
chromium@465841      1 +- N/A       20      bad       <--
chromium@465844      1 +- N/A       20      bad
chromium@465856      1 +- N/A       20      bad
chromium@465880      1 +- N/A       20      bad
chromium@465976      1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.top_25_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8981155673788662160

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4985450705453056


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Duplicate)
Labels: Pri-2
This has been reverted and the test has stopped failing. Please update with any news please.
My patch was relanded at https://chromium.googlesource.com/chromium/src/+/7800a474d39eacc36c6c247f6a956e15f5d2489a

We're now working on performance regression in  issue 714874 
(Reg: c#8) Oh sorry, I assumed this was perf regression issue. The crash should be fixed by  issue 713914 .
Components: Blink>Workers
Labels: M-60 Type-Bug-Regression
Status: Fixed (was: Assigned)
Let me close this issue based on c#12-14.
Cc: u...@chromium.org nedngu...@google.com nhiroki@chromium.org
 Issue 715732  has been merged into this issue.

Sign in to add a comment