New issue
Advanced search Search tips

Issue 714150 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 706474



Sign in to add a comment

Window Dragging Crashes in --mus

Project Member Reported by jonr...@chromium.org, Apr 21 2017

Issue description

April 20th's ToT

Run chrome --mus

Try to reposition the browser window.

Received signal 11 SEGV_MAPERR 000000000060
#0 0x555e2c221a71 __interceptor_backtrace
#1 0x7fb5e4786c9c base::debug::StackTrace::StackTrace()
#2 0x7fb5e4785c9c base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fb5c674c330 <unknown>
#4 0x7fb5d50dbe82 ash::DragWindowResizer::DragWindowResizer()
#5 0x7fb5d50da33b ash::DragWindowResizer::Create()
#6 0x555e2dbd3402 ash::mus::ShellPortMash::CreateDragWindowResizer()
#7 0x7fb5d518f7a5 ash::CreateWindowResizer()
#8 0x7fb5d5179ac0 ash::wm::WmToplevelWindowEventHandler::AttemptToStartDrag()
#9 0x7fb5d517724b ash::wm::WmToplevelWindowEventHandler::HandleMousePressed()
#10 0x7fb5d5176740 ash::wm::WmToplevelWindowEventHandler::OnMouseEvent()
#11 0x7fb5d9750e26 ui::EventDispatcher::DispatchEventToEventHandlers()
#12 0x7fb5d974fec7 ui::EventDispatcher::ProcessEvent()
#13 0x7fb5d974f752 ui::EventDispatcherDelegate::DispatchEvent()
#14 0x7fb5d975288f ui::EventProcessor::OnEventFromSource()
#15 0x7fb5d9753967 ui::EventSource::SendEventToSink()
#16 0x7fb5d9267d32 aura::WindowTreeClient::OnWindowInputEvent()
#17 0x7fb5d931ef04 ui::mojom::WindowTreeClientStubDispatch::Accept()
#18 0x7fb5e4cbff3c mojo::InterfaceEndpointClient::HandleValidatedMessage()
#19 0x7fb5e4cd6aa2 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#20 0x7fb5e4cd56ed mojo::internal::MultiplexRouter::Accept()
#21 0x7fb5e4cb7b88 mojo::Connector::ReadSingleMessage()
#22 0x7fb5e4cb8d2b mojo::Connector::ReadAllAvailableMessages()
#23 0x7fb5e4c7f3bd mojo::SimpleWatcher::OnHandleReady()
#24 0x7fb5e4788e19 base::debug::TaskAnnotator::RunTask()
#25 0x7fb5e4803cc4 base::MessageLoop::RunTask()
#26 0x7fb5e4804a2c base::MessageLoop::DeferOrRunPendingTask()
#27 0x7fb5e4805f2b base::MessageLoop::DoWork()
#28 0x7fb5e480c8d1 base::MessagePumpLibevent::Run()
#29 0x7fb5e4803286 base::MessageLoop::RunHandler()
#30 0x7fb5e488e86a base::RunLoop::Run()
#31 0x555e2e1eaee0 ChromeBrowserMainParts::MainMessageLoopRun()
#32 0x7fb5dd0a3011 content::BrowserMainLoop::RunMainMessageLoopParts()
#33 0x7fb5dd0ab5c6 content::BrowserMainRunnerImpl::Run()
#34 0x7fb5dd095e6f content::BrowserMain()
#35 0x7fb5de78a286 content::ContentMainRunnerImpl::Run()
#36 0x7fb5c5e58b81 service_manager::Main()
#37 0x7fb5de78736a content::ContentMain()
#38 0x555e2c2a9b3f ChromeMain
#39 0x7fb5c617ef45 __libc_start_main
#40 0x555e2c1d31b3 <unknown>
  r8: 00006060003f55c0  r9: 00006060003f55c0 r10: 0000000000000800 r11: 0000000000000001
 r12: 000060600087b7e0 r13: 00000ff6b7b6d498 r14: 0000000000000000 r15: 000060600087b7e8
  di: 0000000000000060  si: 00007fb5d5650460  bp: 00007fff58dd0820  bx: 00000c0c0010f6fd
  dx: 000060c0000f04c0  ax: 0000000000000001  cx: 0000000000000000  sp: 00007fff58dd0800
  ip: 00007fb5d50dbe82 efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000006
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000060
[end of stack trace]


Followup crash from WindowTree when trying to handle the unexpected shutdown:

#0 0x55f81a34da71 [16508:16508:0421/105509.784259:784018373615:ERROR:mash_runner.cc(162)] Main process exiting because service content_packaged_services quit unexpectedly.
__interceptor_backtrace
#1 0x7f2ad0ea2c9c base::debug::StackTrace::StackTrace()
#2 0x7f2ad0ea1c9c base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7f2ab2e68330 <unknown>
#4 0x55f8214caa3c ui::ws::WindowTree::HasRoot()
#5 0x55f8214af9e1 ui::ws::WindowManagerState::GetEventTargetClientId()
#6 0x55f8215020ed ui::ws::EventDispatcher::GetCurrentMouseCursor()
#7 0x55f8214bea24 ui::ws::WindowServer::OnWindowReordered()
#8 0x55f8215197b1 ui::ws::ServerWindow::ReorderImpl()
#9 0x55f821515a8e ui::ws::ServerWindow::RemoveTransientWindow()
#10 0x55f8214c7828 ui::ws::WindowTree::DestroyWindows()
#11 0x55f8214c6b34 ui::ws::WindowTree::~WindowTree()
#12 0x55f8214c7b3e ui::ws::WindowTree::~WindowTree()
#13 0x55f8214b7a76 ui::ws::WindowServer::DestroyTree()
#14 0x7f2ad13de9da mojo::InterfaceEndpointClient::NotifyError()
#15 0x7f2ad13f36be mojo::internal::MultiplexRouter::ProcessNotifyErrorTask()
#16 0x7f2ad13ee8fc mojo::internal::MultiplexRouter::ProcessTasks()
#17 0x7f2ad13ea5a6 mojo::internal::MultiplexRouter::OnPipeConnectionError()
#18 0x7f2ad13d3188 mojo::Connector::HandleError()
#19 0x7f2ad139b3bd mojo::SimpleWatcher::OnHandleReady()
#20 0x7f2ad0ea4e19 base::debug::TaskAnnotator::RunTask()
#21 0x7f2ad0f1fcc4 base::MessageLoop::RunTask()
#22 0x7f2ad0f20a2c base::MessageLoop::DeferOrRunPendingTask()
#23 0x7f2ad0f21f2b base::MessageLoop::DoWork()
#24 0x7f2ad0f288d1 base::MessagePumpLibevent::Run()
#25 0x7f2ad0f1f286 base::MessageLoop::RunHandler()
#26 0x7f2ad0faa86a base::RunLoop::Run()
#27 0x55f81a3dc07d MashRunner::StartChildApp()
#28 0x55f81a3df524 _ZN4base8internal7InvokerINS0_9BindStateIM10MashRunnerFvN4mojo16InterfaceRequestIN15service_manager5mojom7ServiceEEEEJNS0_17UnretainedWrapperIS3_EEEEEFvS9_EE3RunEPNS0_13BindStateBaseEOS9_
#29 0x55f81c2b3548 service_manager::RunStandaloneService()
#30 0x55f81a3d9604 MashRunner::RunChild()
#31 0x55f81a3d92eb MashRunner::Run()
#32 0x55f81a3dc63e MashMain()
#33 0x55f81a3d5b07 ChromeMain
#34 0x7f2ab289af45 __libc_start_main
#35 0x55f81a2ff1b3 <unknown>
  r8: 00006040000b64b0  r9: 0000000000000000 r10: 0000000000002000 r11: 00000c2a0014f4df
 r12: 00000c2c000014b2 r13: 0000617000000520 r14: 000061600000a590 r15: 0000000000000000
  di: 0000000000000000  si: 000061500009ea00  bp: 00007ffc26fba160  bx: 000061500009ea00
  dx: 00000c0800016c00  ax: 0000000000000070  cx: 000000000000000e  sp: 00007ffc26fba160
  ip: 000055f8214caa3c efl: 0000000000010246 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000070
[end of stack trace]

 
Cc: sky@chromium.org
Labels: -Pri-3 mustash-2 Pri-1
Still happens on link with ToT r468701

I think the problem is a null Shell::Get()->mouse_cursor_filter() (which is-a MouseCursorEventFilter and is only created in classic ash)

Comment 2 by sky@chromium.org, May 3 2017

I believe we can enable MouseCursorEventFilter now that simplified display management is there, but I need to verify that.

Comment 3 by sky@chromium.org, May 4 2017

Blockedon: 706474

Comment 4 by sky@chromium.org, May 5 2017

Owner: sky@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5888e81e68aff997094e675cccfe09c559d5f4b

commit a5888e81e68aff997094e675cccfe09c559d5f4b
Author: sky <sky@chromium.org>
Date: Fri May 05 17:56:31 2017

chromeos: enable MouseCursorEventFilter for mushrome

Now that mushrome creates a WindowTreeTreeHostManager it can create a
MouseCursorEventFilter. Also updates test expectation as a bunch of
tests were relying on this.

BUG= 714150 , 706474 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2868463002
Cr-Commit-Position: refs/heads/master@{#469715}

[modify] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/ash/shell.cc
[modify] https://crrev.com/a5888e81e68aff997094e675cccfe09c559d5f4b/testing/buildbot/filters/ash_mus_unittests.filter

Comment 6 by sky@chromium.org, May 5 2017

Status: Fixed (was: Started)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment