Answer in suggest text is not being read aloud by ChromeVox |
|||||||||
Issue description[branching from http://crbug.com/703374#c8] With ChromeVox enabled, the suggestion text (e.g. "weather in los angeles" in the attached screenshot) is being read aloud but the answer text (e.g. "70°F Fri") is not being read aloud. This is a regression. The answer text was made available in http://crrev.com/1311593004. The code that I added to omnibox_result_view.cc is still there and I can verify that when selecting an answer the following code runs: in OnSelected(): NotifyAccessibilityEvent(ui::AX_EVENT_ALERT, true); in GetAccessibleNodeData(ui::AxNodeData*): node_data->SetName(<accessible text>); <accessible text> is, in my example: "weather los angeles, answer, 71 °F Fri". dtsent: lpalmaro suggested that you would be able to help investigate this issue. Do you have any idea why this code is no longer causing the text to be read aloud?
,
May 2 2017
,
May 5 2017
The issue is that you're relying on an event that can get interrupted by other events, so I don't think this ever worked in all cases: log: event: alert what's the weather in los angeles, answer, 63 °F Fri <ChromeVox speaks the above text> log: event: textChanged Address and search bar <ChromeVox speaks "right now, deleted" which correctly interrupts the first event for text to speech> A few ways to fix this: 1. suppress text change events when there's an answer 2. override the accessible description for the url omnibox text field to contain the answer. 3. Try giving the result view "selection" (see ui/accessibility/ax_enums.idl). NotifyAccessibilityEvent(ui::AX_EVENT_SELECTION, true); I slightly prefer 1 or 3 because 2 only gets outputted when the text field receives focus. "
,
May 5 2017
,
May 8 2017
,
May 9 2017
dtseng: Thanks for the help. Approach 3 seems to work well. I tested it on all the old and new answer types and heard each of the answers read successfully. https://codereview.chromium.org/2871973002
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97e8179a439eb85276dd8fefa806133b1c965eca commit 97e8179a439eb85276dd8fefa806133b1c965eca Author: jdonnelly <jdonnelly@chromium.org> Date: Tue May 09 19:18:32 2017 Use ui::AX_EVENT_SELECTION to read aloud omnibox suggestion answers. The previous approach (ui::AX_EVENT_ALERT) allowed the speaking to be interrupted by other events. BUG= 714148 Review-Url: https://codereview.chromium.org/2871973002 Cr-Commit-Position: refs/heads/master@{#470404} [modify] https://crrev.com/97e8179a439eb85276dd8fefa806133b1c965eca/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
,
May 10 2017
,
May 10 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b643f525589405784c8e465cd5eae3304bac85c9 commit b643f525589405784c8e465cd5eae3304bac85c9 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Fri May 12 20:02:09 2017 Use ui::AX_EVENT_SELECTION to read aloud omnibox suggestion answers. The previous approach (ui::AX_EVENT_ALERT) allowed the speaking to be interrupted by other events. BUG= 714148 Review-Url: https://codereview.chromium.org/2871973002 Cr-Original-Commit-Position: refs/heads/master@{#470404} Review-Url: https://codereview.chromium.org/2880843002 . Cr-Commit-Position: refs/branch-heads/3071@{#536} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/b643f525589405784c8e465cd5eae3304bac85c9/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
,
May 12 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by emilyschechter@chromium.org
, May 2 2017Labels: -Pri-2 Pri-1