New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714129 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Page referrer data should only be sent to the CWS if the SafeBrowsing preference is enabled.

Project Member Reported by robertshield@chromium.org, Apr 21 2017

Issue description

Chrome Version: 58
OS: Win, OSX, ChromeOS

What steps will reproduce the problem?
(1) Disable SafeBrowsing
(2) Install an inline extension
(3) Observe (using e.g. ethereal) referrer data still being sent to the Chrome Web Store.

What is the expected result?
Disabling SafeBrowsing should disable the transmission of referrer data to the CWS.

What happens instead?
It doesn't.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Labels: Merge-Request-58
Components: Platform>Extensions
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 21 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Request-59 M-59
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 22 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Apr 23 2017

Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
Cc: dullweber@chromium.org
Components: Privacy
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 24 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da19a8bdd38e8b0d0a16c52a5c76023b073fdaf5

commit da19a8bdd38e8b0d0a16c52a5c76023b073fdaf5
Author: Robert Shield <robertshield@chromium.org>
Date: Mon Apr 24 15:23:06 2017

Gate sending referrers to CWS on whether the profile has SafeBrowsing enabled.

BUG= 714129 

Review-Url: https://codereview.chromium.org/2831263003
Cr-Commit-Position: refs/heads/master@{#466402}
(cherry picked from commit a603f32b1aa3556586f75909a2c73d3006b92edf)

Review-Url: https://codereview.chromium.org/2837823003 .
Cr-Commit-Position: refs/branch-heads/3071@{#162}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/da19a8bdd38e8b0d0a16c52a5c76023b073fdaf5/chrome/browser/extensions/webstore_inline_installer.cc
[modify] https://crrev.com/da19a8bdd38e8b0d0a16c52a5c76023b073fdaf5/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

Labels: -Merge-Review-58 Merge-Rejected-58
Rejecting merge to M58 based on internal mail thread. Thank you.
Labels: -Hotlist-Merge-Review
Status: Fixed (was: Assigned)

Sign in to add a comment