Issue metadata
Sign in to add a comment
|
Regression : 'Show Google Now cards in the Launcher' option is seen misplaced at 'Search engine' section in chrome://md-settings |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3071.15/9460.5.0 Candy,Minnie and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign in to user -> Go to chrome://md-settings (2)Now at 'Search engine' section observe 'Show Google Now cards in the Launcher' option (Please refer screenshot) Expected: 'Show Google Now cards in the Launcher' option should not be misplaced Actual: Instead 'Show Google Now cards in the Launcher' option is seen misplaced This is Regression issue as same is working fine in 58.0.3029.78/9334.52.0 dev-channel Daisy @stevenjb: Please confirm the Issue
,
Apr 21 2017
if it's also dependent on search engine, yes it should be indented. my bad.
,
Apr 24 2017
LGTM
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ee9a70477b5f291ddfeae7f6b57716cf814075b commit 8ee9a70477b5f291ddfeae7f6b57716cf814075b Author: dbeam <dbeam@chromium.org> Date: Tue Apr 25 02:01:24 2017 MD Settings: indent "OK Google" row in "Search engine" section R=stevenjb@chromium.org BUG= 714103 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2842543002 Cr-Commit-Position: refs/heads/master@{#466869} [modify] https://crrev.com/8ee9a70477b5f291ddfeae7f6b57716cf814075b/chrome/browser/resources/settings/search_page/search_page.html
,
Apr 25 2017
,
Apr 25 2017
another potential merge candidate
,
Apr 26 2017
,
Apr 26 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2de6097fb0f17cbbf507acc4e54f3c022809864 commit b2de6097fb0f17cbbf507acc4e54f3c022809864 Author: Dan Beam <dbeam@chromium.org> Date: Wed Apr 26 18:58:57 2017 MD Settings: indent "OK Google" row in "Search engine" section R=stevenjb@chromium.org BUG= 714103 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2842543002 Cr-Commit-Position: refs/heads/master@{#466869} (cherry picked from commit 8ee9a70477b5f291ddfeae7f6b57716cf814075b) Review-Url: https://codereview.chromium.org/2843083002 . Cr-Commit-Position: refs/branch-heads/3071@{#234} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/b2de6097fb0f17cbbf507acc4e54f3c022809864/chrome/browser/resources/settings/search_page/search_page.html
,
May 8 2017
Verified on ChromeOS 9460.30.0, 59.0.3071.41 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Apr 21 2017