New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714096 link

Starred by 1 user
Status: Duplicate
Merged: issue 773269
Owner:
treib@chromium.org
Closed: Oct 2017
Cc:
mastiz@chromium.org
█ sfiera@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Improve test coverage for desktop NTP impressions

Project Member Reported by mastiz@chromium.org, Apr 21 2017 
Bugs like https://bugs.chromium.org/p/chromium/issues/detail?id=703165 should be better covered by tests, possibly browser tests.

Comment 1 by mastiz@chromium.org, Apr 21 2017 

treib@: assigning this to you for now, but I can otherwise eventually pick it up as well, thx.

Comment 2 by mastiz@chromium.org, Apr 21 2017

Cc: sfiera@chromium.org

Comment 3 by treib@chromium.org, Apr 25 2017

Cc: mastiz@chromium.org
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
We do have a bunch of browser tests for the local NTP here: chrome/browser/ui/search/local_ntp_browsertest.cc

We'll have to figure out how to inject a fake NTPTiles instance, but then it should be easy to write such tests.

(This only covers the local NTP, since the remote one is essentially impossible to test in browser_tests. But for metrics tests this should be good enough.)

Comment 4 by treib@chromium.org, Apr 26 2017

Components: UI>Browser>NewTabPage

Comment 5 by treib@chromium.org, Oct 12 2017

Mergedinto: 773269
Status: Duplicate (was: Assigned)
We have some browser tests for desktop NTP impression metrics now.
►

Sign in to add a comment