New issue
Advanced search Search tips

Issue 714076 link

Starred by 1 user
Status: Fixed
Owner:
ricea@chromium.org
Closed: Apr 2017
Cc:
domenic@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Avoid unhandled rejections from ReadableStream pipeThrough()

Project Member Reported by ricea@chromium.org, Apr 21 2017 
The implementation of pipeThrough() has an issue that if the underlying call to pipeTo() fails for any reason, the rejection will not be handled. This change prevents an unhandled rejection error by always handling rejection from pipeTo() in the implementation of pipeThrough().

This is already implemented in the Streams standard and on trunk. This issue is for merging the implementation to M59.

The change has extensive web platform tests, and has also been tested manually in Canary 60.0.3077.0.

Requesting merge to M59.

Comment 1 by ricea@chromium.org, Apr 21 2017 

The CL to be merged is https://codereview.chromium.org/2796633002/.

Comment 2 by ricea@chromium.org, Apr 21 2017

Status: Assigned (was: Started)

Comment 3 by ricea@chromium.org, Apr 21 2017

Components: Blink>Network>StreamsAPI
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 22 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1f38b5f8bbfe40aacfafabe89dc1de7f465db9d

commit d1f38b5f8bbfe40aacfafabe89dc1de7f465db9d
Author: Adam Rice <ricea@chromium.org>
Date: Mon Apr 24 02:07:56 2017

[marge-m59] Add "mark promise as handled" change to pipeThrough()

Update the implementation of ReadableStream pipeThrough() with standard change
https://github.com/whatwg/streams/commit/94140088224c1a0e219c630378d1fa7985d657a9

This makes it mark the Promise returned by pipeTo() as handled to avoid
uncatchable rejections when pipeTo fails.

TBR=tyoshino
BUG= 714076 

Review-Url: https://codereview.chromium.org/2796633002
Cr-Commit-Position: refs/heads/master@{#464718}
(cherry picked from commit 1e9fa3b2e7dca2ba228b9720570512676ed23798)

Review-Url: https://codereview.chromium.org/2837753002 .
Cr-Commit-Position: refs/branch-heads/3071@{#153}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[delete] https://crrev.com/1a502b46093265ccb60c5deaf3c5707138e26be8/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through-expected.txt
[delete] https://crrev.com/1a502b46093265ccb60c5deaf3c5707138e26be8/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.dedicatedworker-expected.txt
[delete] https://crrev.com/1a502b46093265ccb60c5deaf3c5707138e26be8/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.serviceworker.https-expected.txt
[delete] https://crrev.com/1a502b46093265ccb60c5deaf3c5707138e26be8/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.sharedworker-expected.txt
[modify] https://crrev.com/d1f38b5f8bbfe40aacfafabe89dc1de7f465db9d/third_party/WebKit/Source/core/streams/ReadableStream.js

Comment 6 by ricea@chromium.org, Apr 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment