New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 714075 link

Starred by 2 users
Status: Verified
Owner:
fukino@chromium.org
Closed: Apr 2017
Cc:
xiy...@chromium.org
█ dspaid@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 706017
issue 713556



Sign in to add a comment

Migration UI: Restart the system, not only Chrome, after the migration finishes.

Project Member Reported by fukino@chromium.org, Apr 21 2017 
At this moment, Migration UI restarts Chrome after the migration process finishes (either succeeded or failed).
It should be safer to restart the system to make sure that state in cryptohome (mount points, etc...) are re-initialized after the migration process.

This is separated from  Issue 713556 .
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75aa8c950b7aa4b9e0fe8404335294f3576431b8

commit 75aa8c950b7aa4b9e0fe8404335294f3576431b8
Author: fukino <fukino@chromium.org>
Date: Fri Apr 21 16:19:55 2017

cros: Reboot the system after encryption migration finishes.

It should be safer to restart the system to make sure that cryptohome's states
(mount points, etc...) are re-initialized after the migration process.

BUG= 714075 
TEST=manually tested the reboot senario after migration

Review-Url: https://codereview.chromium.org/2836603002
Cr-Commit-Position: refs/heads/master@{#466355}

[modify] https://crrev.com/75aa8c950b7aa4b9e0fe8404335294f3576431b8/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc

Comment 2 by uekawa@google.com, Apr 24 2017

Labels: ArcExt4Migration

Comment 3 by fukino@chromium.org, Apr 25 2017

Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8d7ed552859f846757e420b58f75bde0fe51b4b

commit f8d7ed552859f846757e420b58f75bde0fe51b4b
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Apr 26 10:06:53 2017

cros: Reboot the system after encryption migration finishes.

It should be safer to restart the system to make sure that cryptohome's states
(mount points, etc...) are re-initialized after the migration process.

BUG= 714075 
TEST=manually tested the reboot senario after migration
TBR=xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2836603002
Cr-Commit-Position: refs/heads/master@{#466355}
(cherry picked from commit 75aa8c950b7aa4b9e0fe8404335294f3576431b8)

Review-Url: https://codereview.chromium.org/2845553002 .
Cr-Commit-Position: refs/branch-heads/3071@{#221}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f8d7ed552859f846757e420b58f75bde0fe51b4b/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc

Comment 6 by fukino@chromium.org, Apr 26 2017

Status: Fixed (was: Started)

Comment 7 by sdantul...@chromium.org, May 8 2017

Status: Verified (was: Fixed)
Verified on 9532.0.0, 60.0.3092.0
►

Sign in to add a comment