New issue
Advanced search Search tips

Issue 714069 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

[css-grid][css-align] Update CSSMetadata.js used by DevTools

Project Member Reported by r...@igalia.com, Apr 21 2017

Issue description


During the development of CSS Grid Layout and the alignment properties related,
we were sending some PRs to CodeMirror project in GitHub.

However we were missing the file:
Source/devtools/front_end/sdk/CSSMetadata.js

That file doesn't have a clue bout Grid Layout and alignment properties,
it'd be nice to take a look into it and add them.

 
Pendayungasmara9@gmail.com

Comment 2 by e...@chromium.org, Apr 24 2017

Components: -Blink>Layout>Grid
Labels: -Type-Bug Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8582d8e8c2d42a9ae105280b77f7f8a34979075c

commit 8582d8e8c2d42a9ae105280b77f7f8a34979075c
Author: rego <rego@igalia.com>
Date: Thu May 11 10:43:27 2017

DevTools: Add CSS Grid Layout properties to CSSMetadata.js

The list of properties from the spec:
https://drafts.csswg.org/css-grid/#property-index

BUG= 714069 

Review-Url: https://codereview.chromium.org/2875613002
Cr-Commit-Position: refs/heads/master@{#470906}

[modify] https://crrev.com/8582d8e8c2d42a9ae105280b77f7f8a34979075c/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js

Comment 4 by r...@igalia.com, May 11 2017

Owner: r...@igalia.com
Status: Started (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2125fea63367c21af67cddccb5ba50d9309070d

commit f2125fea63367c21af67cddccb5ba50d9309070d
Author: rego <rego@igalia.com>
Date: Fri May 12 12:05:46 2017

DevTools: Add CSS Box Alignment properties to CSSMetadata.js

The list of properties from the spec:
https://drafts.csswg.org/css-align/#property-index

BUG= 714069 

Review-Url: https://codereview.chromium.org/2880593002
Cr-Commit-Position: refs/heads/master@{#471278}

[modify] https://crrev.com/f2125fea63367c21af67cddccb5ba50d9309070d/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js

Comment 6 by r...@igalia.com, May 12 2017

Status: Fixed (was: Started)

Sign in to add a comment