Issue 714060 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	gambard@chromium.org
Closed:	Apr 2017
Cc:	ios-bugs@chromium.org
Components:	Internals
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Bug

performSelector: is triggering a warning with ARC

Project Member Reported by gambard@chromium.org, Apr 21 2017

Issue description

Doing performSelector: with a selector created with a string or elsewhere in the program (i.e. doing :[target performSelector:NSSelectorFromString(@"someMethod")];) triggers a warning with ARC.
Doing [target performSelector:@selector(@"someMethod")]; is fine.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc

commit d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc
Author: gambard <gambard@chromium.org>
Date: Fri Apr 21 14:59:18 2017

Change target+selector for block in InfoBarView

InfoBarView used a target and a selector for sending the information that a
link has been clicked. This is triggering a warning when compiling with ARC.
This CL changes this by using a block instead.

BUG= 714060 

Review-Url: https://codereview.chromium.org/2831293002
Cr-Commit-Position: refs/heads/master@{#466335}

[modify] https://crrev.com/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc/ios/chrome/browser/infobars/confirm_infobar_controller+protected.h
[modify] https://crrev.com/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc/ios/chrome/browser/infobars/confirm_infobar_controller.mm
[modify] https://crrev.com/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc/ios/chrome/browser/passwords/update_password_infobar_controller.mm
[modify] https://crrev.com/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc/ios/chrome/browser/translate/before_translate_infobar_controller.mm
[modify] https://crrev.com/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc/ios/chrome/browser/ui/infobars/infobar_view.h
[modify] https://crrev.com/d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc/ios/chrome/browser/ui/infobars/infobar_view.mm

Comment 2 by gambard@chromium.org, Apr 21 2017

Status: Fixed (was: Assigned)

►

Issue 714060 link

Issue metadata

performSelector: is triggering a warning with ARC

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

Comment 1 Deleted

Comment 2 by gambard@chromium.org, Apr 21 2017

Comment 2 Deleted

Sign in to add a comment