New issue
Advanced search Search tips

Issue 714045 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Apr 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Material components cannot be rolled

Project Member Reported by gambard@chromium.org, Apr 21 2017 
Material Components cannot be rolled to the last version because some files were added and the BUILD.gn does not add them automatically.

Comment 1 by gambard@chromium.org, Apr 21 2017 

The new files are:
src/components/private/Math/src/MDCMath.h
src/components/private/Math/src/MaterialMath.h

src/components/private/Math is also a new directory.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc02781edef7413fc635f75bafa721e28b695ccf

commit dc02781edef7413fc635f75bafa721e28b695ccf
Author: gambard <gambard@chromium.org>
Date: Fri Apr 21 10:26:45 2017

Roll MaterialComponents to be7b95b05d0e6257c59546a3f45264202f046e3b

This CL rolls MaterialComponents to its latest version and add the new files to
BUILD.gn to fix the build.

BUG= 714045 

Review-Url: https://codereview.chromium.org/2832133003
Cr-Commit-Position: refs/heads/master@{#466304}

[modify] https://crrev.com/dc02781edef7413fc635f75bafa721e28b695ccf/DEPS
[modify] https://crrev.com/dc02781edef7413fc635f75bafa721e28b695ccf/ios/third_party/material_components_ios/BUILD.gn

Comment 3 by gambard@chromium.org, Apr 21 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment