MacOsX native notifications show as a banner when at 0% |
||||
Issue descriptionThis is because we are using the actual progress as an indicator instead of the fact that is a progress notification.
,
Apr 22 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2017
Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c85518e8978da444d30b4eeda37e6c26a7657525 commit c85518e8978da444d30b4eeda37e6c26a7657525 Author: Miguel Garcia <miguelg@chromium.org> Date: Mon Apr 24 09:44:53 2017 Use notification type to detect progress notifications BUG= 714029 Review-Url: https://codereview.chromium.org/2818373004 Cr-Commit-Position: refs/heads/master@{#465225} (cherry picked from commit df7bcad619555a798f21fa9ab52c81204cbb6315) Review-Url: https://codereview.chromium.org/2838563002 . Cr-Commit-Position: refs/branch-heads/3071@{#158} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/c85518e8978da444d30b4eeda37e6c26a7657525/chrome/browser/notifications/notification_platform_bridge_mac.mm [modify] https://crrev.com/c85518e8978da444d30b4eeda37e6c26a7657525/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
,
Apr 24 2017
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c85518e8978da444d30b4eeda37e6c26a7657525 commit c85518e8978da444d30b4eeda37e6c26a7657525 Author: Miguel Garcia <miguelg@chromium.org> Date: Mon Apr 24 09:44:53 2017 Use notification type to detect progress notifications BUG= 714029 Review-Url: https://codereview.chromium.org/2818373004 Cr-Commit-Position: refs/heads/master@{#465225} (cherry picked from commit df7bcad619555a798f21fa9ab52c81204cbb6315) Review-Url: https://codereview.chromium.org/2838563002 . Cr-Commit-Position: refs/branch-heads/3071@{#158} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/c85518e8978da444d30b4eeda37e6c26a7657525/chrome/browser/notifications/notification_platform_bridge_mac.mm [modify] https://crrev.com/c85518e8978da444d30b4eeda37e6c26a7657525/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm |
||||
►
Sign in to add a comment |
||||
Comment 1 by miguelg@chromium.org
, Apr 21 2017