New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 714024 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

elide origins in OSX notifications to etld+1

Project Member Reported by miguelg@chromium.org, Apr 21 2017

Issue description

This is a requirement from the security team in order to launch OSX native notifications

 
https://codereview.chromium.org/2827543003 fixes the issue, it landed one day after branch point and it's already working in canary.
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 22 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by gov...@chromium.org, Apr 23 2017

Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/316658c697579c935e107d3583948f19f53cad09

commit 316658c697579c935e107d3583948f19f53cad09
Author: Miguel Garcia <miguelg@chromium.org>
Date: Mon Apr 24 09:47:00 2017

Display ETLD+1 instead of the full domain in MacOSX native notifications

BUG= 714024 

Review-Url: https://codereview.chromium.org/2827543003
Cr-Commit-Position: refs/heads/master@{#465242}
(cherry picked from commit d59da4c16d22505774ca9f9eae89402bec6efdc2)

Review-Url: https://codereview.chromium.org/2835113002 .
Cr-Commit-Position: refs/branch-heads/3071@{#159}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/316658c697579c935e107d3583948f19f53cad09

commit 316658c697579c935e107d3583948f19f53cad09
Author: Miguel Garcia <miguelg@chromium.org>
Date: Mon Apr 24 09:47:00 2017

Display ETLD+1 instead of the full domain in MacOSX native notifications

BUG= 714024 

Review-Url: https://codereview.chromium.org/2827543003
Cr-Commit-Position: refs/heads/master@{#465242}
(cherry picked from commit d59da4c16d22505774ca9f9eae89402bec6efdc2)

Review-Url: https://codereview.chromium.org/2835113002 .
Cr-Commit-Position: refs/branch-heads/3071@{#159}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm

+1 Me too!

Sign in to add a comment