elide origins in OSX notifications to etld+1 |
||||
Issue descriptionThis is a requirement from the security team in order to launch OSX native notifications
,
Apr 22 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2017
Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/316658c697579c935e107d3583948f19f53cad09 commit 316658c697579c935e107d3583948f19f53cad09 Author: Miguel Garcia <miguelg@chromium.org> Date: Mon Apr 24 09:47:00 2017 Display ETLD+1 instead of the full domain in MacOSX native notifications BUG= 714024 Review-Url: https://codereview.chromium.org/2827543003 Cr-Commit-Position: refs/heads/master@{#465242} (cherry picked from commit d59da4c16d22505774ca9f9eae89402bec6efdc2) Review-Url: https://codereview.chromium.org/2835113002 . Cr-Commit-Position: refs/branch-heads/3071@{#159} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac.mm [modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
,
Apr 24 2017
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/316658c697579c935e107d3583948f19f53cad09 commit 316658c697579c935e107d3583948f19f53cad09 Author: Miguel Garcia <miguelg@chromium.org> Date: Mon Apr 24 09:47:00 2017 Display ETLD+1 instead of the full domain in MacOSX native notifications BUG= 714024 Review-Url: https://codereview.chromium.org/2827543003 Cr-Commit-Position: refs/heads/master@{#465242} (cherry picked from commit d59da4c16d22505774ca9f9eae89402bec6efdc2) Review-Url: https://codereview.chromium.org/2835113002 . Cr-Commit-Position: refs/branch-heads/3071@{#159} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac.mm [modify] https://crrev.com/316658c697579c935e107d3583948f19f53cad09/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
,
Aug 28 2017
+1 Me too! |
||||
►
Sign in to add a comment |
||||
Comment 1 by miguelg@chromium.org
, Apr 21 2017